Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Py_tp_finalize is missing #68533

Closed
encukou opened this issue Jun 1, 2015 · 2 comments
Closed

Py_tp_finalize is missing #68533

encukou opened this issue Jun 1, 2015 · 2 comments
Labels
extension-modules C modules in the Modules dir interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@encukou
Copy link
Member

encukou commented Jun 1, 2015

BPO 24345
Nosy @encukou
Files
  • add-py-tp-finalize.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2015-06-01.15:14:43.667>
created_at = <Date 2015-06-01.13:41:14.555>
labels = ['extension-modules', 'interpreter-core']
title = 'Py_tp_finalize is missing'
updated_at = <Date 2015-06-01.15:14:43.665>
user = 'https://github.com/encukou'

    bugs.python.org fields:

    activity = <Date 2015-06-01.15:14:43.665>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2015-06-01.15:14:43.667>
closer = 'python-dev'
components = ['Extension Modules', 'Interpreter Core']
creation = <Date 2015-06-01.13:41:14.555>
creator = 'petr.viktorin'
dependencies = []
files = ['39585']
hgrepos = []
issue_num = 24345
keywords = ['patch']
message_count = 2.0
messages = ['244581', '244591']
nosy_count = 2.0
nosy_names = ['petr.viktorin', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue24345'
versions = ['Python 3.4', 'Python 3.5', 'Python 3.6']
    @encukou
    Copy link
    Member Author

    encukou commented Jun 1, 2015

    PEP-442 added the tp_finalize member for objects, but there's no corresponding Py_tp_finalize slot. This means that types defined using PyType_FromSpec (and in particular, extensions using the stable ABI) can't take advantage of the new GC finalization mechanism.

    @encukou encukou added extension-modules C modules in the Modules dir interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Jun 1, 2015
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jun 1, 2015

    New changeset 5a354de919aa by Benjamin Peterson in branch '3.5':
    add Py_tp_finalize slot (closes bpo-24345)
    https://hg.python.org/cpython/rev/5a354de919aa

    New changeset 959e998aa167 by Benjamin Peterson in branch 'default':
    merge 3.5 (bpo-24345)
    https://hg.python.org/cpython/rev/959e998aa167

    @python-dev python-dev mannequin closed this as completed Jun 1, 2015
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    extension-modules C modules in the Modules dir interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @encukou