Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch for test_urllib2_net moving tests to use a local server #46681

Closed
voidspace opened this issue Mar 19, 2008 · 3 comments
Closed

Patch for test_urllib2_net moving tests to use a local server #46681

voidspace opened this issue Mar 19, 2008 · 3 comments
Assignees
@gpshead
Labels
tests Tests in the Lib/test dir

Comments

@voidspace
Copy link
Contributor

BPO 2429
Nosy @gpshead, @voidspace
Files
  • network_tests.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/gpshead'
closed_at = <Date 2008-03-29.04:25:11.374>
created_at = <Date 2008-03-19.23:22:35.175>
labels = ['tests']
title = 'Patch for test_urllib2_net moving tests to use a local server'
updated_at = <Date 2008-03-29.04:25:11.373>
user = 'https://github.com/voidspace'

    bugs.python.org fields:

    activity = <Date 2008-03-29.04:25:11.373>
actor = 'gregory.p.smith'
assignee = 'gregory.p.smith'
closed = True
closed_date = <Date 2008-03-29.04:25:11.374>
closer = 'gregory.p.smith'
components = ['Tests']
creation = <Date 2008-03-19.23:22:35.175>
creator = 'michael.foord'
dependencies = []
files = ['9777']
hgrepos = []
issue_num = 2429
keywords = ['patch']
message_count = 3.0
messages = ['64121', '64620', '64681']
nosy_count = 2.0
nosy_names = ['gregory.p.smith', 'michael.foord']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue2429'
versions = ['Python 2.6']
    @voidspace
    Copy link
    Contributor Author

    This patch moves some tests from test_urllib2_net to
    test_urllib2_localnet. The moved tests now use a local server rather
    than going out to external servers.

    Mainly the work of Jerry Seutter - so blame him. ;-)

    @fuzzyman fuzzyman mannequin added the tests Tests in the Lib/test dir label Mar 19, 2008
    @gpshead gpshead self-assigned this Mar 28, 2008
    @gpshead
    Copy link
    Member

    gpshead commented Mar 28, 2008

    committed to trunk in r61998. time to watch the buildbots, it looked
    good to me and passed on my machine. i'll close it once i see buildbot
    test love.

    tweaks i made: I reenabled the commented out ProxyAuth test, as it
    works and I assumed that was leftover from your debugging. I also
    changed the URL in the ProxyAuth test to http://localhost just in case
    it triggered any network traffic.

    @gpshead
    Copy link
    Member

    gpshead commented Mar 29, 2008

    all buildbots seem happy with the new tests.

    @gpshead gpshead closed this as completed Mar 29, 2008
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @gpshead gpshead

    Labels
    tests Tests in the Lib/test dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @gpshead @voidspace