Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test_base64 to use test.support.script_helper #68467

Closed
bobcatfish mannequin opened this issue May 24, 2015 · 5 comments
Closed

Update test_base64 to use test.support.script_helper #68467

bobcatfish mannequin opened this issue May 24, 2015 · 5 comments
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@bobcatfish
Copy link
Mannequin

bobcatfish mannequin commented May 24, 2015

BPO 24279
Nosy @ezio-melotti, @bitdancer, @berkerpeksag, @vadmium
Files
  • issue24279_base64.patch
  • issue24279_base64.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2015-07-25.11:19:42.492>
created_at = <Date 2015-05-24.20:13:11.187>
labels = ['type-feature', 'tests']
title = 'Update test_base64 to use test.support.script_helper'
updated_at = <Date 2015-07-25.11:19:42.490>
user = 'https://bugs.python.org/bobcatfish'

    bugs.python.org fields:

    activity = <Date 2015-07-25.11:19:42.490>
actor = 'berker.peksag'
assignee = 'none'
closed = True
closed_date = <Date 2015-07-25.11:19:42.492>
closer = 'berker.peksag'
components = ['Tests']
creation = <Date 2015-05-24.20:13:11.187>
creator = 'bobcatfish'
dependencies = []
files = ['39485', '39709']
hgrepos = []
issue_num = 24279
keywords = ['patch']
message_count = 5.0
messages = ['243999', '244000', '245347', '247340', '247342']
nosy_count = 6.0
nosy_names = ['ezio.melotti', 'r.david.murray', 'python-dev', 'berker.peksag', 'martin.panter', 'bobcatfish']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue24279'
versions = ['Python 3.5', 'Python 3.6']
    @bobcatfish
    Copy link
    Mannequin Author

    bobcatfish mannequin commented May 24, 2015

    As described in bpo-9517, many test modules do not make use of the helpers in script_helpers.py to invoke the python interpreter in a subprocess. bpo-9517 will be broken down into several smaller issues so we can address smaller change sets.

    This issue is to update test_base64.py to use script_helpers.py.

    @bobcatfish
    Copy link
    Mannequin Author

    bobcatfish mannequin commented May 24, 2015

    Updated TestMain in test_base64 to use test.support.script_helpers. Split test_encode_file into two tests.

    @bobcatfish
    Copy link
    Mannequin Author

    bobcatfish mannequin commented Jun 14, 2015

    Uploading a new patch, diffed against a public revision so it's reviewable.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jul 25, 2015

    New changeset 8e1291cc8b69 by Berker Peksag in branch '3.5':
    Issue bpo-24279: Update test_base64 to use test.support.script_helper.
    https://hg.python.org/cpython/rev/8e1291cc8b69

    New changeset 472f354c70b8 by Berker Peksag in branch 'default':
    Issue bpo-24279: Update test_base64 to use test.support.script_helper.
    https://hg.python.org/cpython/rev/472f354c70b8

    @berkerpeksag
    Copy link
    Member

    Thanks Christie. I've kept get_output() and changed it to return assert_python_ok().out.

    @berkerpeksag berkerpeksag added the tests Tests in the Lib/test dir label Jul 25, 2015
    @berkerpeksag berkerpeksag added the type-feature A feature request or enhancement label Jul 25, 2015
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @berkerpeksag