New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove_module() needs to save/restore exception state #68236
Comments
import.c's remove_module() is always called with an exception set and can invoke arbitrary code via deallocation; if that code calls PyErr_Clear() (or is sensitive to PyErr_Occurred()) it will lose (or be damaged by) the preexisting exception. |
I've created a PR for this issue. |
Can this be closed, Nick? |
I think this change should be backported. |
Assigning to Nick to decide if he wants to backport it to 3.7 before it's no longer possible. |
It seems that Serhiy backported the fix. |
Belatedly marking this as resolved. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: