Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make fails Objects/typeslots.inc #68222

Closed
ma8ma mannequin opened this issue Apr 23, 2015 · 3 comments
Closed

Make fails Objects/typeslots.inc #68222

ma8ma mannequin opened this issue Apr 23, 2015 · 3 comments
Labels
build The build process and cross-build interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@ma8ma
Copy link
Mannequin

ma8ma mannequin commented Apr 23, 2015

BPO 24034
Nosy @vadmium, @ma8ma
Files
  • 3.4-issue24034-make-fails-typeslots.inc.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2016-07-22.03:41:40.396>
created_at = <Date 2015-04-23.04:47:10.025>
labels = ['interpreter-core', 'build']
title = 'Make fails Objects/typeslots.inc'
updated_at = <Date 2016-07-22.03:41:40.385>
user = 'https://github.com/ma8ma'

    bugs.python.org fields:

    activity = <Date 2016-07-22.03:41:40.385>
actor = 'martin.panter'
assignee = 'none'
closed = True
closed_date = <Date 2016-07-22.03:41:40.396>
closer = 'martin.panter'
components = ['Build', 'Interpreter Core']
creation = <Date 2015-04-23.04:47:10.025>
creator = 'masamoto'
dependencies = []
files = ['39178']
hgrepos = []
issue_num = 24034
keywords = ['patch']
message_count = 3.0
messages = ['241843', '241844', '270969']
nosy_count = 2.0
nosy_names = ['martin.panter', 'masamoto']
pr_nums = []
priority = 'normal'
resolution = 'duplicate'
stage = None
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue24034'
versions = ['Python 3.4', 'Python 3.5']
    @ma8ma
    Copy link
    Mannequin Author

    ma8ma mannequin commented Apr 23, 2015

    Objects/typeslots.inc is broken, and make stop on cygwin-1.7.35-i686.

    If built-in python is not found in make processing, Objects/typeslots.inc generating will fail.
    Because Objects/typeslots.inc is generated using $(PYTHON) in Makefile, but $(PYTHON) variable is a hard-coding value that isn't check a built-in python existent.

    make steps to fail and error message:
    $ ./configure --prefix=/opt/py34
    $ touch Include/typeslots.h
    $ make
    ...
    python.exe ./Objects/typeslots.py < ./Include/typeslots.h > Objects/typeslots.inc
    /bin/sh: python.exe: command not found
    Makefile:851: recipe for target 'Objects/typeslots.inc' failed
    make: *** [Objects/typeslots.inc] Error 127

    Cygwin python executable files:
    $ find /usr/bin/ -name 'python*.exe'
    /usr/bin/python2.7.exe
    /usr/bin/python3.2m.exe

    @ma8ma ma8ma mannequin added build The build process and cross-build interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Apr 23, 2015
    @ma8ma
    Copy link
    Mannequin Author

    ma8ma mannequin commented Apr 23, 2015

    I wrote the patch to replace $(PYTHON).

    Changes:
    Add TYPESLOTSGEN to configure.ac. TYPESLOTSGEN values is the built-in python.
    If the built-in python is not found, TYPESLOTSGEN echoes message that is skipping like ASDLGEN.
    Generated the configure script using autoreconf.
    Modify Makefile.pre.in to replace $(PYTHON) to $(TYPESLOTSGEN).
    And remove $(PYTHON) that isn't used anywhere. It seems already needless.

    Although I understand that the generated file touch can avoid to fail regenerate, I want to check built-in python to generate safer the Objects/typeslots.inc.

    @vadmium
    Copy link
    Member

    vadmium commented Jul 22, 2016

    Sorry nobody acted on your patch earlier. This is the same as bpo-26662, which has a more general patch that does the same sort of thing.

    @vadmium vadmium closed this as completed Jul 22, 2016
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    build The build process and cross-build interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @vadmium