Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test_unicodedata.py to use script_helpers #68169

Closed
bobcatfish mannequin opened this issue Apr 17, 2015 · 6 comments
Closed

Update test_unicodedata.py to use script_helpers #68169

bobcatfish mannequin opened this issue Apr 17, 2015 · 6 comments
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@bobcatfish
Copy link
Mannequin

bobcatfish mannequin commented Apr 17, 2015

BPO 23981
Nosy @ezio-melotti, @bitdancer, @berkerpeksag
Files
  • issue23981_test_unicode.patch
  • issue23981_test_unicode.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2015-10-22.00:30:48.582>
created_at = <Date 2015-04-17.00:00:34.970>
labels = ['type-feature', 'tests']
title = 'Update test_unicodedata.py to use script_helpers'
updated_at = <Date 2015-10-22.00:30:48.581>
user = 'https://bugs.python.org/bobcatfish'

    bugs.python.org fields:

    activity = <Date 2015-10-22.00:30:48.581>
actor = 'berker.peksag'
assignee = 'none'
closed = True
closed_date = <Date 2015-10-22.00:30:48.582>
closer = 'berker.peksag'
components = ['Tests']
creation = <Date 2015-04-17.00:00:34.970>
creator = 'bobcatfish'
dependencies = []
files = ['39080', '39708']
hgrepos = []
issue_num = 23981
keywords = ['patch']
message_count = 6.0
messages = ['241293', '241294', '241299', '245346', '253312', '253313']
nosy_count = 5.0
nosy_names = ['ezio.melotti', 'r.david.murray', 'python-dev', 'berker.peksag', 'bobcatfish']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue23981'
versions = ['Python 3.5', 'Python 3.6']
    @bobcatfish
    Copy link
    Mannequin Author

    bobcatfish mannequin commented Apr 17, 2015

    As described in bpo-9517, many test modules do not make use of the helpers in script_helpers.py to invoke the python interpreter in a subprocess. bpo-9517 will be broken down into several smaller issues so we can address smaller change sets.

    This issue is to update test_unicodedata.py to use script_helpers.py.

    @bobcatfish bobcatfish mannequin added tests Tests in the Lib/test dir type-feature A feature request or enhancement labels Apr 17, 2015
    @bobcatfish
    Copy link
    Mannequin Author

    bobcatfish mannequin commented Apr 17, 2015

    I am working on this now.

    @bobcatfish
    Copy link
    Mannequin Author

    bobcatfish mannequin commented Apr 17, 2015

    @r.david.murray, just bugging you b/c you were commenting on bpo-9517, this is ready for a review. It assumes the patch from bpo-9517 has been applied.

    I'm thinking for the next issue I'll tackle a few test modules at once, since this is such a tiny tiny change set (though these tiny change sets would be easier to review - @r.david.murray what do you think?).

    @bobcatfish
    Copy link
    Mannequin Author

    bobcatfish mannequin commented Jun 14, 2015

    Uploading a new patch, diffed against a public revision so it's reviewable.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 22, 2015

    New changeset fbd83224e132 by Berker Peksag in branch '3.5':
    Issue bpo-23981: Update test_unicodedata to use script_helpers
    https://hg.python.org/cpython/rev/fbd83224e132

    New changeset 6315abbf5f71 by Berker Peksag in branch 'default':
    Issue bpo-23981: Update test_unicodedata to use script_helpers
    https://hg.python.org/cpython/rev/6315abbf5f71

    @berkerpeksag
    Copy link
    Member

    Thanks for the patch, Christie.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @berkerpeksag