Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 484 implementation #68161

Closed
gvanrossum opened this issue Apr 16, 2015 · 9 comments
Closed

PEP 484 implementation #68161

gvanrossum opened this issue Apr 16, 2015 · 9 comments
Assignees
@gvanrossum
Labels
type-feature A feature request or enhancement

Comments

@gvanrossum
Copy link
Member

BPO 23973
Nosy @gvanrossum, @larryhastings
Files
  • pep484.diff
  • pep484.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/gvanrossum'
closed_at = None
created_at = <Date 2015-04-16.18:32:03.908>
labels = ['type-feature']
title = 'PEP 484 implementation'
updated_at = <Date 2015-08-09.10:12:45.466>
user = 'https://github.com/gvanrossum'

    bugs.python.org fields:

    activity = <Date 2015-08-09.10:12:45.466>
actor = 'larry'
assignee = 'gvanrossum'
closed = False
closed_date = None
closer = None
components = []
creation = <Date 2015-04-16.18:32:03.908>
creator = 'gvanrossum'
dependencies = []
files = ['39441', '39463']
hgrepos = []
issue_num = 23973
keywords = ['patch']
message_count = 9.0
messages = ['241256', '243713', '243793', '243944', '243946', '247872', '248027', '248301', '248313']
nosy_count = 3.0
nosy_names = ['gvanrossum', 'larry', 'python-dev']
pr_nums = []
priority = 'high'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue23973'
versions = ['Python 3.5']
    @gvanrossum
    Copy link
    Member Author

    I'm creating a release blocker placeholder issue for PEP-484. I think we're going to miss alpha 4 but I am expecting to make beta 1 (and Mark Shannon, the BDFL-Delegate has promised to work within this schedule). Of course it's possible that Mark ends up rejecting the PEP, but I'm betting that we'll be able to hammer out a compromise, so I'm creating this bug to remind myself and other devs of this deadline.

    Also, the only thing to be included is typing.py (and its tests and hopefully some docs, even if the first rev of the docs just points to the PEP).

    @gvanrossum gvanrossum self-assigned this Apr 16, 2015
    @gvanrossum gvanrossum added the type-feature A feature request or enhancement label Apr 16, 2015
    @gvanrossum
    Copy link
    Member Author

    I am going to commit this (or something very close to it) unless I hear an explicit rejection notice from Mark Shannon. Off-list he's promised he'll approve the PEP provisionally, and the window for beta 1 is closing. It's better to iterate than to miss the window entirely.

    @gvanrossum
    Copy link
    Member Author

    New patch.

    @gvanrossum
    Copy link
    Member Author

    This was committed (rev 3e96d7ca3f51). I'm keeping this open because there is more to do (see https://github.com/ambv/typehinting/labels/bug).

    @gvanrossum
    Copy link
    Member Author

    I've opened a separate bug (http://bugs.python.org/issue24272) for docs.

    @gvanrossum
    Copy link
    Member Author

    I'm bumping this up since the CPython repo is several changes behind the typehinting repo (https://github.com/ambv/typehinting/tree/master/prototyping). Those should not miss RC1.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Aug 5, 2015

    New changeset f142b7c7a8e3 by Guido van Rossum in branch '3.5':
    Issue bpo-23973: Update typing.py from GitHub repo.
    https://hg.python.org/cpython/rev/f142b7c7a8e3

    New changeset c9a6ce666ff2 by Guido van Rossum in branch 'default':
    Issue bpo-23973: Update typing.py from GitHub repo. (Merge from 3.5.)
    https://hg.python.org/cpython/rev/c9a6ce666ff2

    @larryhastings
    Copy link
    Contributor

    Can we mark this closed now?

    @gvanrossum
    Copy link
    Member Author

    There's more, but you can reduce the priority now.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @gvanrossum gvanrossum

    Labels
    type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @gvanrossum @larryhastings @kumaraditya303