Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

please fall back to sequential compilation when concurrent doesn't exist #68105

Closed
doko42 opened this issue Apr 11, 2015 · 6 comments
Closed

please fall back to sequential compilation when concurrent doesn't exist #68105

doko42 opened this issue Apr 11, 2015 · 6 comments
Assignees
@PCManticore
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@doko42
Copy link
Member

doko42 commented Apr 11, 2015

BPO 23917
Nosy @brettcannon, @doko42, @PCManticore, @berkerpeksag
Files
  • issue23917.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/PCManticore'
closed_at = <Date 2015-04-22.06:39:58.012>
created_at = <Date 2015-04-11.22:52:09.499>
labels = ['type-bug', 'library']
title = "please fall back to sequential compilation when concurrent doesn't exist"
updated_at = <Date 2015-04-22.06:39:58.010>
user = 'https://github.com/doko42'

    bugs.python.org fields:

    activity = <Date 2015-04-22.06:39:58.010>
actor = 'berker.peksag'
assignee = 'Claudiu.Popa'
closed = True
closed_date = <Date 2015-04-22.06:39:58.012>
closer = 'berker.peksag'
components = ['Library (Lib)']
creation = <Date 2015-04-11.22:52:09.499>
creator = 'doko'
dependencies = []
files = ['39132']
hgrepos = []
issue_num = 23917
keywords = ['patch']
message_count = 6.0
messages = ['240507', '240881', '241561', '241655', '241775', '241776']
nosy_count = 5.0
nosy_names = ['brett.cannon', 'doko', 'Claudiu.Popa', 'python-dev', 'berker.peksag']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue23917'
versions = ['Python 3.5']
    @doko42
    Copy link
    Member Author

    doko42 commented Apr 11, 2015

    issue bpo-16104 introduces parallel byte compilation, however the method is now overly strict when workers > 1 and no concurrent support available. Please just fall back to sequential byte compilation in this case.

    @doko42 doko42 added the stdlib Python modules in the Lib dir label Apr 11, 2015
    @PCManticore
    Copy link
    Mannequin

    PCManticore mannequin commented Apr 14, 2015

    Will do, thanks.

    @PCManticore PCManticore mannequin self-assigned this Apr 14, 2015
    @PCManticore PCManticore mannequin added the type-bug An unexpected behavior, bug, or error label Apr 14, 2015
    @PCManticore
    Copy link
    Mannequin

    PCManticore mannequin commented Apr 19, 2015

    Here's the patch.

    @brettcannon
    Copy link
    Member

    LGTM

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Apr 22, 2015

    New changeset 572dc6bdc0a3 by Berker Peksag in branch 'default':
    Issue bpo-23917: Fall back to sequential compilation when ProcessPoolExecutor doesn't exist.
    https://hg.python.org/cpython/rev/572dc6bdc0a3

    @berkerpeksag
    Copy link
    Member

    Thanks Claudiu.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @PCManticore PCManticore

    Labels
    stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @berkerpeksag @brettcannon @doko42