Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider FreeBSD like any other OS in SOVERSION #68005

Closed
bapt mannequin opened this issue Mar 31, 2015 · 14 comments
Closed

Consider FreeBSD like any other OS in SOVERSION #68005

bapt mannequin opened this issue Mar 31, 2015 · 14 comments
Labels
build The build process and cross-build type-feature A feature request or enhancement

Comments

@bapt
Copy link
Mannequin

bapt mannequin commented Mar 31, 2015

BPO 23817
Nosy @vstinner, @koobs
Files
  • configure_ac.patch: Path against configure.ac
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2015-04-13.07:31:03.609>
created_at = <Date 2015-03-31.12:46:47.387>
labels = ['type-feature', 'build']
title = 'Consider FreeBSD like any other OS in SOVERSION'
updated_at = <Date 2015-04-13.07:31:03.608>
user = 'https://bugs.python.org/bapt'

    bugs.python.org fields:

    activity = <Date 2015-04-13.07:31:03.608>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2015-04-13.07:31:03.609>
closer = 'vstinner'
components = ['Build']
creation = <Date 2015-03-31.12:46:47.387>
creator = 'bapt'
dependencies = []
files = ['38759']
hgrepos = []
issue_num = 23817
keywords = ['patch']
message_count = 14.0
messages = ['239695', '239696', '239698', '239699', '239703', '239708', '239709', '239950', '239954', '240319', '240380', '240381', '240508', '240596']
nosy_count = 4.0
nosy_names = ['vstinner', 'python-dev', 'koobs', 'bapt']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'needs patch'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue23817'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5']
    @bapt
    Copy link
    Mannequin Author

    bapt mannequin commented Mar 31, 2015

    In the configuration script:
    https://hg.python.org/cpython/file/47b2d1ff9743/configure.ac#l963

    There is a special treatment done for FreeBSD, which is not needed, FreeBSD is perfectly fine with multiple digit in soversion.

    @bapt bapt mannequin added the build The build process and cross-build label Mar 31, 2015
    @vstinner
    Copy link
    Member

    https://hg.python.org/cpython/file/47b2d1ff9743/configure.ac#l963

    This command was added by the changeset 6fc10306bf31.

    @bapt
    Copy link
    Mannequin Author

    bapt mannequin commented Mar 31, 2015

    Adding a patch on configure.ac (I bet configure should not be patched but regenerated)

    Considering the comment here: http://bugs.python.org/issue1044395#msg47064 about ldconfig(1) the output of ldconfig(1) is buggy in that regard, and the ports tree does not depends on that anymore so it will perfectly accept the 2 digit name.

    There are no known other things depending on that buggy output

    @koobs
    Copy link

    koobs commented Mar 31, 2015

    +1

    @koobs koobs added the type-feature A feature request or enhancement label Mar 31, 2015
    @vstinner
    Copy link
    Member

    koobs set versions: + Python 2.7, Python 3.4, Python 3.5

    Do you seriously consider to modify Python 2.7 and 3.4? Can it break the backward compatibility?

    I don't know how the SOVERSION thing is used.

    @bapt
    Copy link
    Mannequin Author

    bapt mannequin commented Mar 31, 2015

    Provide more information:
    Here is a description of the problem with the FreeBSD ldconfig(1) problem and why it was a problem with libpython.so.*

    https://wiki.freebsd.org/ports/fix_lib_depends

    Here is the commit that adds the new methode for ports to lookup for libraries installed (not using ldconfig(1):
    https://svnweb.freebsd.org/ports?view=revision&revision=322328
    here is the commit that removes the ancient method:
    https://svnweb.freebsd.org/ports?view=revision&revision=362031

    @bapt
    Copy link
    Mannequin Author

    bapt mannequin commented Mar 31, 2015

    I do not think it is worth changing python 2.7 or python 3.4 given the fact that the .so.1 symlink is not created (which imho it should be a good idea to create but let's go step by step)

    Let's just do it for next python

    @koobs
    Copy link

    koobs commented Apr 3, 2015

    @Haypo, yes, absolutely and no

    We will backport to security-only branches ourselves.

    @vstinner
    Copy link
    Member

    vstinner commented Apr 3, 2015

    Oh, I expected such change to break backward compatibility. If it doesn't,
    it's fine.

    Koobs, would you like to commit the patch?

    @koobs
    Copy link

    koobs commented Apr 9, 2015

    @Haypo, if you could take care of the change in default, 3.4 and 2.7, we can backport the rest downstream. Thank you :)

    @bapt, can you create a separate issue to cover the "create foo.so.X' symlink" request, so python@ (freebsd team) can work to patch locally with an upstream reference

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Apr 9, 2015

    New changeset 7444ac6d93c3 by Victor Stinner in branch 'default':
    Issue bpo-23817: FreeBSD now uses "1.0" the the SOVERSION as other operating
    https://hg.python.org/cpython/rev/7444ac6d93c3

    @vstinner
    Copy link
    Member

    vstinner commented Apr 9, 2015

    Let's just do it for next python

    Ok.

    I don't understand the purpose of SOVERSION, nor why it is an issue to not use dots on FreeBSD. So I don't want to change it in minor Python relases (2.7.x, 3.4.y).

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Apr 11, 2015

    New changeset 0b3027a2abbc by Ned Deily in branch 'default':
    Issue bpo-23817: run autoreconf to update configure.
    https://hg.python.org/cpython/rev/0b3027a2abbc

    @vstinner
    Copy link
    Member

    Issue bpo-23817: run autoreconf to update configure.

    Oh thanks, I forgot to regenerate configure!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    build The build process and cross-build type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @koobs