Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argument Clinic: generate code into separate files by default #67689

Closed
serhiy-storchaka opened this issue Feb 22, 2015 · 7 comments
Closed

Argument Clinic: generate code into separate files by default #67689

serhiy-storchaka opened this issue Feb 22, 2015 · 7 comments
Labels
build The build process and cross-build topic-argument-clinic type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 23501
Nosy @larryhastings, @serhiy-storchaka
Dependencies
  • bpo-23500: Argument Clinic: multiple macro definition
    		•
    Files
  • clinic_file.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2015-04-03.20:54:56.726>
created_at = <Date 2015-02-22.11:04:48.510>
labels = ['type-feature', 'expert-argument-clinic', 'build']
title = 'Argument Clinic: generate code into separate files by default'
updated_at = <Date 2015-04-04.21:48:51.971>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2015-04-04.21:48:51.971>
actor = 'BreamoreBoy'
assignee = 'none'
closed = True
closed_date = <Date 2015-04-03.20:54:56.726>
closer = 'serhiy.storchaka'
components = ['Build', 'Demos and Tools', 'Argument Clinic']
creation = <Date 2015-02-22.11:04:48.510>
creator = 'serhiy.storchaka'
dependencies = ['23500']
files = ['38204']
hgrepos = []
issue_num = 23501
keywords = ['patch']
message_count = 7.0
messages = ['236406', '240036', '240037', '240089', '240090', '240091', '240092']
nosy_count = 4.0
nosy_names = ['larry', 'BreamoreBoy', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue23501'
versions = ['Python 3.5']
    @serhiy-storchaka
    Copy link
    Member Author

    Proposed patch makes Argument Clinic to generate code into separate files by default. This will help maintaining in the case of enhancements of Argument Clinic generation (such as bpo-23492). See thread on http://comments.gmane.org/gmane.comp.python.devel/151585 .

    There is an issue with multiple macro definition in the posix module (see bpo-23500).

    @serhiy-storchaka serhiy-storchaka added build The build process and cross-build type-feature A feature request or enhancement topic-argument-clinic labels Feb 22, 2015
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Apr 3, 2015

    New changeset aa88a18a4aa1 by Serhiy Storchaka in branch 'default':
    Issue bpo-23501: Argumen Clinic now generates code into separate files by default.
    https://hg.python.org/cpython/rev/aa88a18a4aa1

    @larryhastings
    Copy link
    Contributor

    Thanks! I've been meaning to follow up on this. I think CPython should be consistent, one way or another. So I support this change.

    @BreamoreBoy
    Copy link
    Mannequin

    BreamoreBoy mannequin commented Apr 4, 2015

    I think this change in association with that in bpo-23500 is causing builds to fail on Windows.

    error C2065: 'OS_STAT_METHODDEF' : undeclared identifier C:\cpython\Modules\posixmodule.c line 12083

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Apr 4, 2015

    New changeset 17eb29faebde by Serhiy Storchaka in branch 'default':
    Issue bpo-23501: #include "clinic/posixmodule.c.h" was in the section skipped on Windows.
    https://hg.python.org/cpython/rev/17eb29faebde

    @serhiy-storchaka
    Copy link
    Member Author

    Thank you Mark.

    @BreamoreBoy
    Copy link
    Mannequin

    BreamoreBoy mannequin commented Apr 4, 2015

    Serhiy, thank you for the quick fix :)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    build The build process and cross-build topic-argument-clinic type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @serhiy-storchaka @larryhastings