Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Py3K warn using file.softspace #46601

Closed
brettcannon opened this issue Mar 17, 2008 · 6 comments
Closed

Py3K warn using file.softspace #46601

brettcannon opened this issue Mar 17, 2008 · 6 comments
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@brettcannon
Copy link
Member

BPO 2348
Nosy @brettcannon, @birkenfeld, @benjaminp
Files
  • issue2348.diff: diff against r61635
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2008-03-21.20:39:08.832>
created_at = <Date 2008-03-17.19:17:33.886>
labels = ['interpreter-core']
title = 'Py3K warn using file.softspace'
updated_at = <Date 2008-03-21.20:39:08.830>
user = 'https://github.com/brettcannon'

    bugs.python.org fields:

    activity = <Date 2008-03-21.20:39:08.830>
actor = 'georg.brandl'
assignee = 'none'
closed = True
closed_date = <Date 2008-03-21.20:39:08.832>
closer = 'georg.brandl'
components = ['Interpreter Core']
creation = <Date 2008-03-17.19:17:33.886>
creator = 'brett.cannon'
dependencies = []
files = ['9774']
hgrepos = []
issue_num = 2348
keywords = ['patch', '26backport']
message_count = 6.0
messages = ['63716', '63827', '63873', '64077', '64091', '64273']
nosy_count = 4.0
nosy_names = ['brett.cannon', 'georg.brandl', 'benjamin.peterson', 'jeff.balogh']
pr_nums = []
priority = 'critical'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue2348'
versions = ['Python 2.6']
    @brettcannon
    Copy link
    Member Author

    A Py3K warning should be raised if file.whitespace is used in any way.

    @brettcannon brettcannon added release-blocker interpreter-core (Objects, Python, Grammar, and Parser dirs) and removed release-blocker labels Mar 17, 2008
    @brettcannon
    Copy link
    Member Author

    That should read file.softspace.

    @brettcannon brettcannon changed the title Py3K warn using file.whitespace Py3K warn using file.softspace Mar 18, 2008
    @jeffbalogh
    Copy link
    Mannequin

    jeffbalogh mannequin commented Mar 18, 2008

    Attaching a patch that adds {get,set}_attr wrappers for fileobject
    which warn about softspace usage.

    @benjaminp
    Copy link
    Contributor

    I have a few comments:

    1. Please use PyErr_WarnEx.
    2. Please add tests to Lib/test/test_py3kwarn.py

    @jeffbalogh
    Copy link
    Mannequin

    jeffbalogh mannequin commented Mar 19, 2008

    Here's a new patch that uses PyErr_WarnEx, has a test, and even updates
    Misc/NEWS.

    @birkenfeld
    Copy link
    Member

    Committed a simpler patch (the file object already had a getsetlist) in
    r61716.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @brettcannon @birkenfeld @benjaminp