Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make user scripts directory versioned on Windows #67625

Closed
pfmoore opened this issue Feb 10, 2015 · 10 comments
Closed

Make user scripts directory versioned on Windows #67625

pfmoore opened this issue Feb 10, 2015 · 10 comments
Assignees
@zooba
Labels
OS-windows type-feature A feature request or enhancement

Comments

@pfmoore
Copy link
Member

pfmoore commented Feb 10, 2015

BPO 23437
Nosy @pfmoore, @tjguk, @jkloth, @zware, @zooba
Files
  • userscripts.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
closed_at = <Date 2015-02-14.17:53:05.517>
created_at = <Date 2015-02-10.20:46:26.259>
labels = ['type-feature', 'OS-windows']
title = 'Make user scripts directory versioned on Windows'
updated_at = <Date 2015-02-14.20:10:25.814>
user = 'https://github.com/pfmoore'

    bugs.python.org fields:

    activity = <Date 2015-02-14.20:10:25.814>
actor = 'paul.moore'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2015-02-14.17:53:05.517>
closer = 'python-dev'
components = ['Windows']
creation = <Date 2015-02-10.20:46:26.259>
creator = 'paul.moore'
dependencies = []
files = ['38085']
hgrepos = []
issue_num = 23437
keywords = ['patch', 'needs review']
message_count = 10.0
messages = ['235702', '235703', '235716', '235717', '235718', '235980', '235983', '235985', '235986', '235987']
nosy_count = 6.0
nosy_names = ['paul.moore', 'tim.golden', 'jkloth', 'python-dev', 'zach.ware', 'steve.dower']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue23437'
versions = ['Python 3.5']
    @pfmoore
    Copy link
    Member Author

    pfmoore commented Feb 10, 2015

    Patch to make the user scripts directory on Windows %APPDATA%\Python\PythonXY\Scripts rather than %APPDATA%\Python\Scripts.

    See the thread "PEP-370 - per-user scripts directory on Windows" (Feb 10 2015) on python-dev for discussion, but essentially this is to ensure that different Python versions cannot overwrite each others' package scripts when packages are installed into the user site directory.

    Not tested, as I don't yet have Visual Studio 2015 installed. I'll try to obtain and install it when I get the chance.

    @pfmoore pfmoore added OS-windows type-feature A feature request or enhancement labels Feb 10, 2015
    @zooba
    Copy link
    Member

    zooba commented Feb 10, 2015

    You should be able to apply the patch to 3.5.0a1 and test it that way easily enough. Other than the doc changes, it's just .py files. (Building 3.5 with earlier VS versions is also okay right now.)

    @pfmoore
    Copy link
    Member Author

    pfmoore commented Feb 10, 2015

    Cool, I've just run the tests by manually patching a 3.5a0 install. No extra failures, so things look fine. (Interestingly, before patching, test_site "altered the execution environment" but afterwards it didn't - it just succeeded. I don't know if that means anything, but I'm inclined not to worry as it definitely didn't fail.)

    @zooba
    Copy link
    Member

    zooba commented Feb 10, 2015

    How do pip & co. handle the change? I assume they just look in sysconfig and don't think too much about the path...

    @pfmoore
    Copy link
    Member Author

    pfmoore commented Feb 10, 2015

    Sorry, yes pip just installs into %APPDATA%\Python\Python35\Scripts with no issues.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 14, 2015

    New changeset add998f98e31 by Steve Dower in branch 'default':
    Closes bpo-23437: Make user scripts directory versioned on Windows (patch by pmoore)
    https://hg.python.org/cpython/rev/add998f98e31

    @python-dev python-dev mannequin closed this as completed Feb 14, 2015
    @zware
    Copy link
    Member

    zware commented Feb 14, 2015

    This one could use a NEWS entry, and possibly what's new as well.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 14, 2015

    New changeset a2217106ca5e by Steve Dower in branch 'default':
    Issue bpo-23437: Update NEWS and whatsnew/3.5
    https://hg.python.org/cpython/rev/a2217106ca5e

    @zooba
    Copy link
    Member

    zooba commented Feb 14, 2015

    Thanks. I always forget about those.

    @pfmoore
    Copy link
    Member Author

    pfmoore commented Feb 14, 2015

    Sorry, I should probably have added them to the patch in the first place :-)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zooba zooba

    Labels
    OS-windows type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @pfmoore @zooba @zware