Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep http.server.__all__ up to date #67606

Closed
vadmium opened this issue Feb 9, 2015 · 5 comments
Closed

Keep http.server.__all__ up to date #67606

vadmium opened this issue Feb 9, 2015 · 5 comments
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@vadmium
Copy link
Member

vadmium commented Feb 9, 2015

BPO 23418
Nosy @berkerpeksag, @vadmium, @demianbrecht
Files
  • http.server-all.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2015-02-13.18:53:18.236>
created_at = <Date 2015-02-09.07:03:43.897>
labels = ['type-bug', 'library']
title = 'Keep http.server.__all__ up to date'
updated_at = <Date 2015-02-13.18:53:18.235>
user = 'https://github.com/vadmium'

    bugs.python.org fields:

    activity = <Date 2015-02-13.18:53:18.235>
actor = 'berker.peksag'
assignee = 'none'
closed = True
closed_date = <Date 2015-02-13.18:53:18.236>
closer = 'berker.peksag'
components = ['Library (Lib)']
creation = <Date 2015-02-09.07:03:43.897>
creator = 'martin.panter'
dependencies = []
files = ['38051']
hgrepos = []
issue_num = 23418
keywords = ['patch']
message_count = 5.0
messages = ['235594', '235597', '235907', '235910', '235911']
nosy_count = 4.0
nosy_names = ['python-dev', 'berker.peksag', 'martin.panter', 'demian.brecht']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue23418'
versions = ['Python 3.4', 'Python 3.5']
    @vadmium
    Copy link
    Member Author

    vadmium commented Feb 9, 2015

    Here is a patch that adds the Simple/CGIHTTPRequestHandler classes to __all__, and a test case that should help keep it up to date in the future.

    @vadmium vadmium added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Feb 9, 2015
    @berkerpeksag
    Copy link
    Member

    LGTM.

    @demianbrecht
    Copy link
    Mannequin

    demianbrecht mannequin commented Feb 13, 2015

    LGTM.

    +1

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 13, 2015

    New changeset d2dbec7d74d0 by Berker Peksag in branch '3.4':
    Issue bpo-23418: Add missing entries to http.server.__all__.
    https://hg.python.org/cpython/rev/d2dbec7d74d0

    New changeset 03e3e78014ea by Berker Peksag in branch 'default':
    Issue bpo-23418: Add missing entries to http.server.__all__.
    https://hg.python.org/cpython/rev/03e3e78014ea

    @berkerpeksag
    Copy link
    Member

    Fixed. Thanks Martin (also thanks to Demian for the review).

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @berkerpeksag @vadmium