Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport set literals #46588

Closed
brettcannon opened this issue Mar 17, 2008 · 9 comments
Closed

Backport set literals #46588

brettcannon opened this issue Mar 17, 2008 · 9 comments
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@brettcannon
Copy link
Member

BPO 2335
Nosy @gvanrossum, @brettcannon, @rhettinger, @avassalotti, @benjaminp
Files
  • backport_set_literal.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2010-01-09.23:37:29.239>
created_at = <Date 2008-03-17.17:38:45.776>
labels = ['interpreter-core', 'type-bug']
title = 'Backport set literals'
updated_at = <Date 2010-01-09.23:37:29.238>
user = 'https://github.com/brettcannon'

    bugs.python.org fields:

    activity = <Date 2010-01-09.23:37:29.238>
actor = 'alexandre.vassalotti'
assignee = 'none'
closed = True
closed_date = <Date 2010-01-09.23:37:29.239>
closer = 'alexandre.vassalotti'
components = ['Interpreter Core']
creation = <Date 2008-03-17.17:38:45.776>
creator = 'brett.cannon'
dependencies = []
files = ['14650']
hgrepos = []
issue_num = 2335
keywords = ['patch', '26backport']
message_count = 9.0
messages = ['63692', '70455', '91279', '91280', '91284', '91289', '91294', '96256', '97478']
nosy_count = 5.0
nosy_names = ['gvanrossum', 'brett.cannon', 'rhettinger', 'alexandre.vassalotti', 'benjamin.peterson']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue2335'
versions = ['Python 2.7']
    @brettcannon
    Copy link
    Member Author

    Set literals need to be backported.

    @brettcannon brettcannon added release-blocker interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error and removed release-blocker labels Mar 17, 2008
    @benjaminp
    Copy link
    Contributor

    I'm going to defer this to 2.7.

    @avassalotti
    Copy link
    Member

    Here is a patch for backporting set literals to the trunk.

    @rhettinger
    Copy link
    Contributor

    Guido, I thought you had decided for this to just be a 3.x feature.

    Alex, if this goes forward, were you also going to change the repr() for
    sets and the corresponding pprint code? Are set comprehensions on the
    radar screen also. IMO, these all go hand in hand.

    @avassalotti
    Copy link
    Member

    I think we should keep the repr() of sets as is to avoid breaking any
    code. And yes, I plan to port set comprehensions along with dict
    comprehension.

    @gvanrossum
    Copy link
    Member

    Raymond, I know you see this differently, but personally I don't see a
    problem with 2.7 getting additional backports of 3.x features, as long
    as they are backwards compatible. While personally I wouldn't spend
    effort on this particular backport, I don't see a problem when someone
    volunteers a patch. In this specific case, I am fine with accepting set
    literals and set comprehensions as new syntax. I do agree that repr()
    needs to be kept the same as it was under 2.6.

    @gvanrossum gvanrossum removed their assignment Aug 5, 2009
    @rhettinger
    Copy link
    Contributor

    These all seem fine to me. Was just checking in because I thought you
    had previously pronounced otherwise.

    @avassalotti
    Copy link
    Member

    If there are no objections, I will commit this patch later this week.

    @avassalotti
    Copy link
    Member

    It been a long week, but this patch is now committed as r77400.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    5 participants
    @brettcannon @avassalotti @benjaminp @rhettinger @gvanrossum