Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_ssl fails on OS X 10.10.2 with latest patch level of OpenSSL libs #67534

Closed
ned-deily opened this issue Jan 29, 2015 · 6 comments
Closed

test_ssl fails on OS X 10.10.2 with latest patch level of OpenSSL libs #67534

ned-deily opened this issue Jan 29, 2015 · 6 comments

Comments

@ned-deily
Copy link
Member

BPO 23345
Nosy @pitrou, @ned-deily

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2015-02-05.06:28:13.346>
created_at = <Date 2015-01-29.02:04:12.722>
labels = []
title = 'test_ssl fails on OS X 10.10.2 with latest patch level of OpenSSL libs'
updated_at = <Date 2015-02-05.06:28:13.344>
user = 'https://github.com/ned-deily'

bugs.python.org fields:

activity = <Date 2015-02-05.06:28:13.344>
actor = 'ned.deily'
assignee = 'none'
closed = True
closed_date = <Date 2015-02-05.06:28:13.346>
closer = 'ned.deily'
components = []
creation = <Date 2015-01-29.02:04:12.722>
creator = 'ned.deily'
dependencies = []
files = []
hgrepos = []
issue_num = 23345
keywords = []
message_count = 6.0
messages = ['234935', '234956', '234957', '234961', '235419', '235420']
nosy_count = 3.0
nosy_names = ['pitrou', 'ned.deily', 'python-dev']
pr_nums = []
priority = 'critical'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue23345'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5']
@ned-deily
Copy link
Member Author

With the latest maintenance release of OS X 10.10 (10.10.2), the OpenSSL libs have reached a patch level that fails the sanity test in test_ssl:

test_ssl: testing with 'OpenSSL 0.9.8zc 15 Oct 2014' (0, 9, 8, 28, 15)
under Mac ('10.10.2', ('', '', ''), 'x86_64')
HAS_SNI = True
OP_ALL = 0x 7ff
[...]
======================================================================
FAIL: test_openssl_version (test.test_ssl.BasicSocketTests)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/py/dev/3x/source/Lib/test/test_ssl.py", line 309, in test_openssl_version
    self.assertLessEqual(patch, 26)
AssertionError: 28 not less than or equal to 26

Is there anything special about 26 or can the value just be bumped?

@pitrou
Copy link
Member

pitrou commented Jan 29, 2015

The assumption was that the patch level represented a letter (from 'a' to 'z'), but we can certainly relax that.

@pitrou
Copy link
Member

pitrou commented Jan 29, 2015

Er... OS X 10.10 ships OpenSSL 0.9.8??

@ned-deily
Copy link
Member Author

Yep, 0.9.8 is the newest and presumably last major of version of OpenSSL in OS X. OpenSSL has been officially deprecated by Apple in OS X since OS X 10.7; it's only there for third-party products shipped by Apple in OS X, like Python. Their own apps use Apple's own frameworks like SecTransform and CommonCrypto. (See, for example, http://rentzsch.tumblr.com/post/33696323211/wherein-i-write-apples-technote-about-openssl-on) Apple also ships 0.9.7 shared libs in 10.10 for really old applications.

@python-dev
Copy link
Mannequin

python-dev mannequin commented Feb 5, 2015

New changeset 49f07942fbd7 by Ned Deily in branch '2.7':
Issue bpo-23345: Prevent test_ssl failures with large OpenSSL patch level
https://hg.python.org/cpython/rev/49f07942fbd7

New changeset 52932cd7f003 by Ned Deily in branch '3.4':
Issue bpo-23345: Prevent test_ssl failures with large OpenSSL patch level
https://hg.python.org/cpython/rev/52932cd7f003

New changeset 62b322b82f00 by Ned Deily in branch 'default':
Issue bpo-23345: merge from 3.4
https://hg.python.org/cpython/rev/62b322b82f00

@ned-deily
Copy link
Member Author

Fixed for 2.7.10, 3.4.3, and 3.5.0.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pitrou @ned-deily