Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Windows installer #67449

Closed
zooba opened this issue Jan 17, 2015 · 7 comments
Closed

Update Windows installer #67449

zooba opened this issue Jan 17, 2015 · 7 comments
Assignees
@zooba
Labels
OS-windows release-blocker type-feature A feature request or enhancement

Comments

@zooba
Copy link
Member

zooba commented Jan 17, 2015

BPO 23260
Nosy @larryhastings, @tjguk, @zware, @zooba
Files
  • 23260_1.diff
  • README.txt: Overview of the new installer
  • 23260_2.diff
  • 23260_3.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
closed_at = <Date 2015-02-06.06:13:20.997>
created_at = <Date 2015-01-17.23:12:41.490>
labels = ['type-feature', 'OS-windows', 'release-blocker']
title = 'Update Windows installer'
updated_at = <Date 2015-02-06.06:13:20.996>
user = 'https://github.com/zooba'

    bugs.python.org fields:

    activity = <Date 2015-02-06.06:13:20.996>
actor = 'steve.dower'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2015-02-06.06:13:20.997>
closer = 'steve.dower'
components = ['Windows']
creation = <Date 2015-01-17.23:12:41.490>
creator = 'steve.dower'
dependencies = []
files = ['37751', '37752', '37754', '37838']
hgrepos = []
issue_num = 23260
keywords = ['patch']
message_count = 7.0
messages = ['234203', '234204', '234214', '234217', '234628', '235463', '235464']
nosy_count = 6.0
nosy_names = ['larry', 'tim.golden', 'BreamoreBoy', 'python-dev', 'zach.ware', 'steve.dower']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue23260'
versions = ['Python 3.5']
    @zooba
    Copy link
    Member Author

    zooba commented Jan 17, 2015

    Updating the installer for better security and robustness. Large patch coming soon (just getting an issue number to put in NEWS).

    @zooba zooba self-assigned this Jan 17, 2015
    @zooba zooba added OS-windows type-feature A feature request or enhancement labels Jan 17, 2015
    @zooba
    Copy link
    Member Author

    zooba commented Jan 17, 2015

    Patch. I'm also revising Doc/using/windows.rst, but I don't want to delay the initial reviews.

    I don't think this is perfect, but it works well enough for the first alpha (scheduled for 8 Feb), so I want to get it in and stabilised now rather than at the last minute. There'll be more features and work to do.

    There's a README.txt file (which I'll attach next) that has an overview of the installer. It'll be worth reading that first before looking at the code.

    And apologies if the code makes no sense. I'm happy to explain sections, but WiX is about 90% magic (and the rest is MSBuild magic) and so any explanation is likely to be unsatisfactory. I've been working with both of these pretty intently for the last few years and I still don't feel like I've mastered them...

    @zooba
    Copy link
    Member Author

    zooba commented Jan 18, 2015

    As I expected, shortly after posting this I find a significant issue with the way the installer will work.

    Expect a revised patch soon :)

    @zooba
    Copy link
    Member Author

    zooba commented Jan 18, 2015

    New patch with some changes to how optional debug symbols and binaries are handled. (I misunderstood how a particular WiX feature worked...)

    @zooba
    Copy link
    Member Author

    zooba commented Jan 24, 2015

    Updated patch, and hopefully it will make it into review this time.

    I deliberately excluded the image for the using/windows.rst documentation but you can see it at http://imgur.com/CdQaBmp

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 6, 2015

    New changeset e7dbef447157 by Steve Dower in branch 'default':
    Issue bpo-23260: Update Windows installer
    https://hg.python.org/cpython/rev/e7dbef447157

    @zooba
    Copy link
    Member Author

    zooba commented Feb 6, 2015

    Got about as many reviews as I expected, but the builds have been going fine and I want this checked in before alpha, so in it goes :)

    @zooba zooba closed this as completed Feb 6, 2015
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    This was referenced May 30, 2022
    Open
    Open
    Open
    Open
    Open
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zooba zooba

    Labels
    OS-windows release-blocker type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @zooba