Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename IDLE's "Windows" menu item to "Window" #67369

Closed
AlSweigart mannequin opened this issue Jan 7, 2015 · 9 comments
Closed

Rename IDLE's "Windows" menu item to "Window" #67369

AlSweigart mannequin opened this issue Jan 7, 2015 · 9 comments
Labels
topic-IDLE type-bug An unexpected behavior, bug, or error

Comments

@AlSweigart
Copy link
Mannequin

AlSweigart mannequin commented Jan 7, 2015

BPO 23180
Nosy @terryjreedy, @ned-deily
Files
  • patch.diff: Fix for the issue.
  • idle_window_doc_rename.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2015-01-18.05:13:02.515>
created_at = <Date 2015-01-07.07:16:27.318>
labels = ['expert-IDLE', 'type-bug']
title = 'Rename IDLE\'s "Windows" menu item to "Window"'
updated_at = <Date 2015-01-18.05:13:02.514>
user = 'https://bugs.python.org/AlSweigart'

    bugs.python.org fields:

    activity = <Date 2015-01-18.05:13:02.514>
actor = 'ned.deily'
assignee = 'none'
closed = True
closed_date = <Date 2015-01-18.05:13:02.515>
closer = 'ned.deily'
components = ['IDLE']
creation = <Date 2015-01-07.07:16:27.318>
creator = 'Al.Sweigart'
dependencies = []
files = ['37622', '37679']
hgrepos = []
issue_num = 23180
keywords = ['patch']
message_count = 9.0
messages = ['233566', '233605', '233833', '233863', '233874', '234215', '234219', '234220', '234221']
nosy_count = 4.0
nosy_names = ['terry.reedy', 'ned.deily', 'python-dev', 'Al.Sweigart']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue23180'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5']
    @AlSweigart
    Copy link
    Mannequin Author

    AlSweigart mannequin commented Jan 7, 2015

    Currently IDLE's top-level menu item is "Windows" on Windows & Linux but is specifically changed to "Window" on OS X to match mac's look and feel. See https://hg.python.org/cpython/rev/1b3b6b1982aa

    The singular "Window" is the standard menu name on all platforms, and "Windows" should never be used. Note: Photoshop, Blender, Visual Studio, IntelliJ, WinMerge, HxD, and Notepad++ on Windows use the "Window" name in their menus. I can't find any that use "Windows".

    @AlSweigart AlSweigart mannequin added topic-IDLE type-bug An unexpected behavior, bug, or error labels Jan 7, 2015
    @terryjreedy
    Copy link
    Member

    I guess the logic of the plural was that the submenu lists windows to select from. The logic of the singular is that the submenu lets a user select and jump to *a* window, just as the file menu allows one to select and open (if needed) *a* file.

    Somewhat oddly, Notepad++ Window menu has a Windows entry.

    Please mark Idle issues for exactly 2.7, 3.4, and 3.5.

    @AlSweigart
    Copy link
    Mannequin Author

    AlSweigart mannequin commented Jan 11, 2015

    Will do, re marking IDLE issues for 2.7, 3.4, and 3.5 only. Thanks for the heads up.

    @ned-deily
    Copy link
    Member

    Also, the IDLE help text file (Lib/idlelib/help.txt) and the IDLE documentation in the Standard Library Reference (Doc/library/idle.rst) refer to the "Windows" menu and would need to be updated.

    @AlSweigart
    Copy link
    Mannequin Author

    AlSweigart mannequin commented Jan 12, 2015

    Added another patch for the documentation changes for the menu renaming.

    @ned-deily
    Copy link
    Member

    LGTM. Terry, should I apply them?

    @terryjreedy
    Copy link
    Member

    I cannot currently test or commit a patch. So go ahead.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jan 18, 2015

    New changeset 9a451aaa8ddb by Ned Deily in branch '2.7':
    Issue bpo-23180: Rename IDLE "Windows" menu item to "Window".
    https://hg.python.org/cpython/rev/9a451aaa8ddb

    New changeset 8c0e5b507794 by Ned Deily in branch '3.4':
    Issue bpo-23180: Rename IDLE "Windows" menu item to "Window".
    https://hg.python.org/cpython/rev/8c0e5b507794

    New changeset af092c1d3747 by Ned Deily in branch 'default':
    Issue bpo-23180: merge from 3.4
    https://hg.python.org/cpython/rev/af092c1d3747

    @ned-deily
    Copy link
    Member

    Thanks for the patches, Al. Pushed for release in 2.7.10, 3.4.3, and 3.5.0.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    topic-IDLE type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @ned-deily @terryjreedy