Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PEP 3135 (super()) #46565

Closed
gvanrossum opened this issue Mar 16, 2008 · 6 comments
Closed

Update PEP 3135 (super()) #46565

gvanrossum opened this issue Mar 16, 2008 · 6 comments
Assignees
@gvanrossum
Labels
docs Documentation in the Doc dir

Comments

@gvanrossum
Copy link
Member

BPO 2312
Nosy @gvanrossum, @birkenfeld
Files
  • pep3135: the new PEP
  • pep-3135.diff: diff for the PEP
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/gvanrossum'
closed_at = <Date 2009-03-11.19:15:44.071>
created_at = <Date 2008-03-16.21:38:56.765>
labels = ['docs']
title = 'Update PEP 3135 (super())'
updated_at = <Date 2009-03-11.19:15:44.070>
user = 'https://github.com/gvanrossum'

    bugs.python.org fields:

    activity = <Date 2009-03-11.19:15:44.070>
actor = 'gvanrossum'
assignee = 'gvanrossum'
closed = True
closed_date = <Date 2009-03-11.19:15:44.071>
closer = 'gvanrossum'
components = ['Documentation']
creation = <Date 2008-03-16.21:38:56.765>
creator = 'gvanrossum'
dependencies = []
files = ['13303', '13305']
hgrepos = []
issue_num = 2312
keywords = ['patch']
message_count = 6.0
messages = ['63600', '83462', '83474', '83475', '83476', '83477']
nosy_count = 3.0
nosy_names = ['gvanrossum', 'georg.brandl', 'lieryan']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue2312'
versions = ['Python 3.0']
    @gvanrossum
    Copy link
    Member Author

    The super() PEP currently is completely wrong w.r.t. reality. The
    implementation is solid and won't change. The PEP just needs to be
    rewritten to match reality.

    @gvanrossum gvanrossum added the docs Documentation in the Doc dir label Mar 16, 2008
    @lieryan
    Copy link
    Mannequin

    lieryan mannequin commented Mar 11, 2009

    The possible new PEP-3135, however I'm not that familiar with the
    implementation of the new super, thus please review whether it is "right
    w.r.t. reality". I'm writing only from whatever I can determine from
    observing the behavior of super in python 3.0.1

    Probably not related, but while playing with super, I noticed several
    things, I'm not sure about whether this is bug or design decision:

    • super() in normal function is SystemError, instead of SyntaxError or a
      more descriptive error

    btw, is "__class__" related to "__this_class__" alt implementation? I
    assume yes, so I removed the alt implementation for __this_class__

    @gvanrossum
    Copy link
    Member Author

    Thanks for contributing. However since you reformatted the whole file
    it's kind of hard to see what you changed, which makes review laborious.
    Could you try to upload a unified diff relative to the PEP source code
    in Subversion?

    @lieryan
    Copy link
    Mannequin

    lieryan mannequin commented Mar 11, 2009

    Here is the unified diff.

    @gvanrossum
    Copy link
    Member Author

    Thanks! Reviewing now...

    @gvanrossum gvanrossum assigned gvanrossum and unassigned birkenfeld Mar 11, 2009
    @gvanrossum
    Copy link
    Member Author

    Submitted as revision 70312, with some additional changes. I suppose it
    could use some more work (e.g. adding the penultimate proposal to the
    History section) but I'll leave that to others. (Lie, if you feel like
    writing that history section, just add it to this bug.)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @gvanrossum gvanrossum

    Labels
    docs Documentation in the Doc dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @birkenfeld @gvanrossum