Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pep8 asyncore.py #67253

Closed
liuchang mannequin opened this issue Dec 16, 2014 · 2 comments
Closed

pep8 asyncore.py #67253

liuchang mannequin opened this issue Dec 16, 2014 · 2 comments
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@liuchang
Copy link
Mannequin

liuchang mannequin commented Dec 16, 2014

BPO 23064
Nosy @bitdancer
Files
  • pep8-asyncore.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2014-12-16.13:53:18.685>
created_at = <Date 2014-12-16.09:41:22.413>
labels = ['type-feature', 'library']
title = 'pep8 asyncore.py'
updated_at = <Date 2014-12-16.13:53:18.684>
user = 'https://bugs.python.org/liuchang'

    bugs.python.org fields:

    activity = <Date 2014-12-16.13:53:18.684>
actor = 'r.david.murray'
assignee = 'none'
closed = True
closed_date = <Date 2014-12-16.13:53:18.685>
closer = 'r.david.murray'
components = ['Library (Lib)']
creation = <Date 2014-12-16.09:41:22.413>
creator = 'liu chang'
dependencies = []
files = ['37462']
hgrepos = ['287']
issue_num = 23064
keywords = ['patch']
message_count = 2.0
messages = ['232730', '232742']
nosy_count = 2.0
nosy_names = ['r.david.murray', 'liu chang']
pr_nums = []
priority = 'normal'
resolution = 'rejected'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue23064'
versions = ['Python 3.4']
    @liuchang
    Copy link
    Mannequin Author

    liuchang mannequin commented Dec 16, 2014

    PEP-8 Lib/asycore.py.

    @liuchang liuchang mannequin added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Dec 16, 2014
    @bitdancer
    Copy link
    Member

    Thanks for the effort, but we do not apply PEP-8-only patches. The small improvements in readability do not justify the costs of code churn and the chance of introducing bugs.

    (Also, FYI, PEP-8 discourages using \ for line continuation.)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @bitdancer