Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test_uuid #67204

Closed
serhiy-storchaka opened this issue Dec 8, 2014 · 2 comments
Closed

Improve test_uuid #67204

serhiy-storchaka opened this issue Dec 8, 2014 · 2 comments
Assignees
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 23015
Nosy @serhiy-storchaka
Files
  • test_uuid.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
    closed_at = <Date 2014-12-15.12:13:18.365>
    created_at = <Date 2014-12-08.20:33:09.989>
    labels = ['type-feature', 'tests']
    title = 'Improve test_uuid'
    updated_at = <Date 2014-12-15.12:13:18.364>
    user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2014-12-15.12:13:18.364>
    actor = 'serhiy.storchaka'
    assignee = 'serhiy.storchaka'
    closed = True
    closed_date = <Date 2014-12-15.12:13:18.365>
    closer = 'serhiy.storchaka'
    components = ['Tests']
    creation = <Date 2014-12-08.20:33:09.989>
    creator = 'serhiy.storchaka'
    dependencies = []
    files = ['37389']
    hgrepos = []
    issue_num = 23015
    keywords = ['patch']
    message_count = 2.0
    messages = ['232327', '232655']
    nosy_count = 2.0
    nosy_names = ['python-dev', 'serhiy.storchaka']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue23015'
    versions = ['Python 2.7', 'Python 3.4', 'Python 3.5']

    @serhiy-storchaka
    Copy link
    Member Author

    Proposed patch makes following changes to test_uuid.

    • Report the test as skipped if this method to determine MAC address doesn't work on this platform.
    • Output found node value if test ran with -vv.
    • Output node values in hexadecimal if node tests fail.
    • Check that 47 bit is clear for node values obtained from network card.
    • Remove unused commented out code.
    • Move internal functions tests to separate test class.

    @serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir type-feature A feature request or enhancement labels Dec 8, 2014
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Dec 15, 2014

    New changeset f972583c7c4f by Serhiy Storchaka in branch '2.7':
    Issue bpo-23015: Improved testing of the uuid module.
    https://hg.python.org/cpython/rev/f972583c7c4f

    New changeset 3551dc8af54e by Serhiy Storchaka in branch '3.4':
    Issue bpo-23015: Improved testing of the uuid module.
    https://hg.python.org/cpython/rev/3551dc8af54e

    New changeset fd1d994afe52 by Serhiy Storchaka in branch 'default':
    Issue bpo-23015: Improved testing of the uuid module.
    https://hg.python.org/cpython/rev/fd1d994afe52

    @serhiy-storchaka serhiy-storchaka self-assigned this Dec 15, 2014
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant