Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'ip' for uuid.getnode() #67091

Closed
bru mannequin opened this issue Nov 19, 2014 · 6 comments
Closed

Use 'ip' for uuid.getnode() #67091

bru mannequin opened this issue Nov 19, 2014 · 6 comments
Assignees
@serhiy-storchaka
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@bru
Copy link
Mannequin

bru mannequin commented Nov 19, 2014

BPO 22902
Nosy @vstinner, @serhiy-storchaka
Files
  • uuid_find_mac_with_ip.patch: Patch for 'ip' usage in uuid.getnode()
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2014-11-30.18:44:10.533>
created_at = <Date 2014-11-19.15:16:34.732>
labels = ['type-feature', 'library']
title = "Use 'ip' for uuid.getnode()"
updated_at = <Date 2014-11-30.18:44:10.532>
user = 'https://bugs.python.org/bru'

    bugs.python.org fields:

    activity = <Date 2014-11-30.18:44:10.532>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2014-11-30.18:44:10.533>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2014-11-19.15:16:34.732>
creator = 'bru'
dependencies = []
files = ['37228']
hgrepos = []
issue_num = 22902
keywords = ['patch']
message_count = 6.0
messages = ['231382', '231384', '231388', '231891', '231898', '231899']
nosy_count = 4.0
nosy_names = ['vstinner', 'python-dev', 'serhiy.storchaka', 'bru']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue22902'
versions = ['Python 3.5']
    @bru
    Copy link
    Mannequin Author

    bru mannequin commented Nov 19, 2014

    Only linux, uuid.getnode() will use the Unix ddl, then ifconfig, then random. ifconfig is disappearing in favour of ip (from iproute2), which should be used.
    This patch ads _ip_getnode getter to uuid.getnode()

    @bru bru mannequin added the stdlib Python modules in the Lib dir label Nov 19, 2014
    @vstinner
    Copy link
    Member

    IMO such change can wait for Python 3.5.

    @serhiy-storchaka
    Copy link
    Member

    LGTM.

    @serhiy-storchaka
    Copy link
    Member

    Bruno, could you please sign a Contributor Licensing Agreement?

    http://www.python.org/psf/contrib/contrib-form/
    http://www.python.org/psf/contrib/

    @serhiy-storchaka serhiy-storchaka self-assigned this Nov 30, 2014
    @serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Nov 30, 2014
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 30, 2014

    New changeset 64bb01bce12c by Serhiy Storchaka in branch 'default':
    Issue bpo-22902: The "ip" command is now used on Linux to determine MAC address
    https://hg.python.org/cpython/rev/64bb01bce12c

    @serhiy-storchaka
    Copy link
    Member

    Thank you for your contribution Bruno.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @serhiy-storchaka serhiy-storchaka

    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @serhiy-storchaka