Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid to use coroutine with add_signal_handler() #67030

Closed
LudovicGasc mannequin opened this issue Nov 10, 2014 · 4 comments
Closed

Avoid to use coroutine with add_signal_handler() #67030

LudovicGasc mannequin opened this issue Nov 10, 2014 · 4 comments
Labels
topic-asyncio

Comments

@LudovicGasc
Copy link
Mannequin

LudovicGasc mannequin commented Nov 10, 2014

BPO 22841
Nosy @gvanrossum, @vstinner, @1st1
Files
  • add_signal_handler_no_coroutines.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2014-11-25.14:36:13.681>
created_at = <Date 2014-11-10.23:35:47.861>
labels = ['expert-asyncio']
title = 'Avoid to use coroutine with add_signal_handler()'
updated_at = <Date 2014-11-25.14:36:13.681>
user = 'https://bugs.python.org/LudovicGasc'

    bugs.python.org fields:

    activity = <Date 2014-11-25.14:36:13.681>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2014-11-25.14:36:13.681>
closer = 'vstinner'
components = ['asyncio']
creation = <Date 2014-11-10.23:35:47.861>
creator = 'Ludovic.Gasc'
dependencies = []
files = ['37170']
hgrepos = []
issue_num = 22841
keywords = ['patch']
message_count = 4.0
messages = ['230984', '231177', '231178', '231179']
nosy_count = 5.0
nosy_names = ['gvanrossum', 'vstinner', 'python-dev', 'Ludovic.Gasc', 'yselivanov']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue22841'
versions = ['Python 3.4', 'Python 3.5']
    @LudovicGasc
    Copy link
    Mannequin Author

    LudovicGasc mannequin commented Nov 10, 2014

    Hi,

    Victor Stinner suggested me during PyCON-FR to send you this:
    It's a pico-patch to forbid a coroutine as parameter of add_signal_handler().

    I've added a test for that, the patch is based on the latest commit in Tulip.

    Thanks for your feedback.

    Regards.

    @LudovicGasc LudovicGasc mannequin added the topic-asyncio label Nov 10, 2014
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 14, 2014

    New changeset d244e1770f1b by Guido van Rossum in branch '3.4':

    @gvanrossum
    Copy link
    Member

    Applied to upstream tulip, 3.4, and 3.5. Thanks Ludovic!

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 14, 2014

    New changeset 44e77709daa4 by Guido van Rossum in branch 'default':

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    topic-asyncio
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @gvanrossum