Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert re tests to unittest #67027

Closed
serhiy-storchaka opened this issue Nov 10, 2014 · 4 comments
Closed

Convert re tests to unittest #67027

serhiy-storchaka opened this issue Nov 10, 2014 · 4 comments
Assignees
@serhiy-storchaka
Labels
tests Tests in the Lib/test dir topic-regex type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 22838
Nosy @terryjreedy, @pitrou, @ezio-melotti, @zware, @serhiy-storchaka
Files
  • re_tests.patch
  • re_tests.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2014-12-01.09:11:47.850>
created_at = <Date 2014-11-10.17:10:56.448>
labels = ['expert-regex', 'type-feature', 'tests']
title = 'Convert re tests to unittest'
updated_at = <Date 2014-12-01.09:11:47.849>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2014-12-01.09:11:47.849>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2014-12-01.09:11:47.850>
closer = 'serhiy.storchaka'
components = ['Regular Expressions', 'Tests']
creation = <Date 2014-11-10.17:10:56.448>
creator = 'serhiy.storchaka'
dependencies = []
files = ['37168', '37199']
hgrepos = []
issue_num = 22838
keywords = ['patch']
message_count = 4.0
messages = ['230966', '231171', '231184', '231916']
nosy_count = 7.0
nosy_names = ['terry.reedy', 'pitrou', 'ezio.melotti', 'mrabarnett', 'python-dev', 'zach.ware', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue22838'
versions = ['Python 3.4', 'Python 3.5']
    @serhiy-storchaka
    Copy link
    Member Author

    Current re tests consists of two parts. One part use unittest and other part import test cases from Lib/test/re_tests.py, checks conditions and prints messages to stdout if they are false.

    Proposed patch converts all test_re to using unittest.

    @serhiy-storchaka serhiy-storchaka self-assigned this Nov 10, 2014
    @serhiy-storchaka serhiy-storchaka added topic-regex tests Tests in the Lib/test dir type-feature A feature request or enhancement labels Nov 10, 2014
    @terryjreedy
    Copy link
    Member

    This needs side-by-side review but there is no review button. Does anyone know why?

    @serhiy-storchaka
    Copy link
    Member Author

    Regenerated patch. Hope this will help.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Dec 1, 2014

    New changeset 21a7a92f4d0c by Serhiy Storchaka in branch '3.4':
    Issue bpo-22838: All test_re tests now work with unittest test discovery.
    https://hg.python.org/cpython/rev/21a7a92f4d0c

    New changeset 258ee94b5bac by Serhiy Storchaka in branch 'default':
    Issue bpo-22838: All test_re tests now work with unittest test discovery.
    https://hg.python.org/cpython/rev/258ee94b5bac

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @serhiy-storchaka serhiy-storchaka

    Labels
    tests Tests in the Lib/test dir topic-regex type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @serhiy-storchaka @terryjreedy