Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

marshal needs a lower stack depth for debug builds on Windows #66923

Closed
zooba opened this issue Oct 26, 2014 · 3 comments
Closed

marshal needs a lower stack depth for debug builds on Windows #66923

zooba opened this issue Oct 26, 2014 · 3 comments
Assignees
@zooba
Labels
tests Tests in the Lib/test dir

Comments

@zooba
Copy link
Member

zooba commented Oct 26, 2014

BPO 22734
Nosy @ncoghlan, @pitrou, @giampaolo, @tiran, @zooba
Files
  • marshal.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
closed_at = <Date 2014-11-01.22:16:57.068>
created_at = <Date 2014-10-26.20:40:05.660>
labels = ['tests']
title = 'marshal needs a lower stack depth for debug builds on Windows'
updated_at = <Date 2014-11-01.22:16:57.067>
user = 'https://github.com/zooba'

    bugs.python.org fields:

    activity = <Date 2014-11-01.22:16:57.067>
actor = 'steve.dower'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2014-11-01.22:16:57.068>
closer = 'steve.dower'
components = ['Tests']
creation = <Date 2014-10-26.20:40:05.660>
creator = 'steve.dower'
dependencies = []
files = ['37024']
hgrepos = []
issue_num = 22734
keywords = ['patch']
message_count = 3.0
messages = ['230037', '230050', '230466']
nosy_count = 6.0
nosy_names = ['ncoghlan', 'pitrou', 'giampaolo.rodola', 'christian.heimes', 'python-dev', 'steve.dower']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue22734'
versions = ['Python 3.5']
    @zooba
    Copy link
    Member Author

    zooba commented Oct 26, 2014

    This patch decreases the stack depth limit for Windows debug builds to prevent the recursion test from failing. (Apparently VC14 uses more stack space for each frame than VC10, but the release build is unaffected.)

    Not sure who the correct nosy for marshal is, so I picked test coverage, as this only really shows up in the tests.

    @zooba zooba self-assigned this Oct 26, 2014
    @zooba zooba added the tests Tests in the Lib/test dir label Oct 26, 2014
    @pitrou
    Copy link
    Member

    pitrou commented Oct 27, 2014

    This looks harmless to me.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 1, 2014

    New changeset c2a3865a59f4 by Steve Dower in branch 'default':
    bpo-22734 marshal needs a lower stack depth for debug builds on Windows
    https://hg.python.org/cpython/rev/c2a3865a59f4

    @zooba zooba closed this as completed Nov 1, 2014
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zooba zooba

    Labels
    tests Tests in the Lib/test dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @zooba @pitrou