Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idle: add help to config dialogs #66915

Closed
terryjreedy opened this issue Oct 25, 2014 · 5 comments
Closed

Idle: add help to config dialogs #66915

terryjreedy opened this issue Oct 25, 2014 · 5 comments
Assignees
Labels
topic-IDLE type-feature A feature request or enhancement

Comments

@terryjreedy
Copy link
Member

BPO 22726
Nosy @terryjreedy, @roseman
Files
  • @config-help-34.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/terryjreedy'
    closed_at = <Date 2015-10-12.02:13:10.134>
    created_at = <Date 2014-10-25.04:46:23.840>
    labels = ['expert-IDLE', 'type-feature']
    title = 'Idle: add help to config dialogs'
    updated_at = <Date 2019-03-21.18:19:30.056>
    user = 'https://github.com/terryjreedy'

    bugs.python.org fields:

    activity = <Date 2019-03-21.18:19:30.056>
    actor = 'terry.reedy'
    assignee = 'terry.reedy'
    closed = True
    closed_date = <Date 2015-10-12.02:13:10.134>
    closer = 'terry.reedy'
    components = ['IDLE']
    creation = <Date 2014-10-25.04:46:23.840>
    creator = 'terry.reedy'
    dependencies = []
    files = ['37010']
    hgrepos = []
    issue_num = 22726
    keywords = ['patch']
    message_count = 5.0
    messages = ['229981', '252371', '252440', '252836', '252837']
    nosy_count = 4.0
    nosy_names = ['terry.reedy', 'markroseman', 'python-dev', 'Saimadhav.Heblikar']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue22726'
    versions = ['Python 2.7', 'Python 3.4', 'Python 3.5', 'Python 3.6']

    @terryjreedy
    Copy link
    Member Author

    At one time, ConfigDialog was given a do-nothing Help button. It was diabled a couple of years ago. This patch restores it for both config dialogs, displaying a text appropriate for both. There are separate functions in anticipation of dialog-specific content. For both, there is the issue of when changes take effect (bpo-22707). For extensions, there might be extension-specific help (bpo-22705).

    @terryjreedy terryjreedy self-assigned this Oct 25, 2014
    @terryjreedy terryjreedy added the type-feature A feature request or enhancement label Oct 25, 2014
    @terryjreedy
    Copy link
    Member Author

    This patch does two things: 1. restore the Help button and make it display something; 2. lower case the method names. The latter is a separate issue, best done in a new file. What is needed for bpo-25313 is tab-specific text.

    Also, now that Config Extenstion uses a list rather than tabs, it couldn be added as a tab to the main dialog, and only one set of button event handlers would be needed. Tab-specific text would be needed first.

    @roseman
    Copy link
    Mannequin

    roseman mannequin commented Oct 6, 2015

    I'm not against online help, but I feel that what's there wouldn't be helpful to someone using IDLE.

    Once this would be extended to per-tab, what are the problem areas that people really need help with? Also keeping in mind we're going to be replacing this dialog (at least for people with tk > 8.4) in the not too distant future.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 12, 2015

    New changeset fd41b05b8227 by Terry Jan Reedy in branch '2.7':
    Issue bpo-22726: Re-activate config dialog help button with some content about
    https://hg.python.org/cpython/rev/fd41b05b8227

    New changeset 01f83efcc44b by Terry Jan Reedy in branch '3.4':
    Issue bpo-22726: Re-activate config dialog help button with some content about
    https://hg.python.org/cpython/rev/01f83efcc44b

    @terryjreedy
    Copy link
    Member Author

    I rewrote the common section to explain what the button do. I did not modify the extensions dialog because I want to finish bpo-24782. bpo-22707 may add more.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    topic-IDLE type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant