Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idle extension configuration and key bindings #66895

Open
terryjreedy opened this issue Oct 23, 2014 · 5 comments
Open

Idle extension configuration and key bindings #66895

terryjreedy opened this issue Oct 23, 2014 · 5 comments
Labels
3.8 only security fixes topic-IDLE type-feature A feature request or enhancement

Comments

@terryjreedy
Copy link
Member

BPO 22706
Nosy @terryjreedy
Files
  • issue22706_1.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2014-10-23.00:17:33.672>
    labels = ['expert-IDLE', 'type-feature', '3.8']
    title = 'Idle extension configuration and key bindings'
    updated_at = <Date 2019-02-21.00:30:26.932>
    user = 'https://github.com/terryjreedy'

    bugs.python.org fields:

    activity = <Date 2019-02-21.00:30:26.932>
    actor = 'terry.reedy'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['IDLE']
    creation = <Date 2014-10-23.00:17:33.672>
    creator = 'terry.reedy'
    dependencies = []
    files = ['37550']
    hgrepos = []
    issue_num = 22706
    keywords = ['patch']
    message_count = 5.0
    messages = ['229848', '232654', '232717', '232810', '336164']
    nosy_count = 2.0
    nosy_names = ['terry.reedy', 'Saimadhav.Heblikar']
    pr_nums = []
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue22706'
    versions = ['Python 3.8']

    @terryjreedy
    Copy link
    Member Author

    In default config-extensions.def, section [X] is followed by section [X_cfgBindings]. In user config-extensions.cfg, the two sections are written independently by the config dialog (key bindings) and by the extensions dialog (the [X]). While having [X] and [X_cfgBindings] separated and even reversed in order seems to still work, it would be nicer if they were written together in the proper order. It might be possible to do this in the user-config writing method in config-handler.

    @terryjreedy terryjreedy added topic-IDLE type-feature A feature request or enhancement labels Oct 23, 2014
    @SaimadhavHeblikar
    Copy link
    Mannequin

    SaimadhavHeblikar mannequin commented Dec 15, 2014

    Need some clarification on this issue. I tried changing the cfgBindings for FormatParagraph. It creates a new key-set and writes the changes to user config-keys.cfg in ~/.idlerc(the keybindings). Any changes made to FormatParagraph in extension dialog(the [X]) are written to the user config-extensions.cfg file in ~/.idlerc.

    Have I understood the issue correctly in saying that the desired outcome is both [X] and [X_cfgBindings] write to config-extensions.cfg in ~/.idlerc?

    @terryjreedy
    Copy link
    Member Author

    When I alter an *extension* key binding (in the keys page of idle pref dialog), the change shows up in .idlerc/config-extensions.cfg, not config-keys.cfg. For instance,

    [ZoomHeight_cfgBindings]
    zoom-height = <Control-Alt-Key-space>

    If I also disable zoom-height, the following appears in a separate part of the same file.

    [XoomHeight]
    enable=False

    For me, the two blocks are already in the same file. The same is true for FormatParagraph. I intended this issue to be about bringing them together in the file, with the [X] block first. You seem to be saying that the current behavior is different on linux. Since FormatParagraph is still special (see bpo-20577), try ZoomHeight also.

    @SaimadhavHeblikar
    Copy link
    Mannequin

    SaimadhavHeblikar mannequin commented Dec 17, 2014

    ZoomHeight behavior on linux is as what you mentioned. Now I have understood this issue. Working on it.

    @terryjreedy
    Copy link
    Member Author

    bpo-27099 (converting built-in extensions to features) made this less important. But it is still relevant to actual extensions. There is a dummy extension, zzdummy, for testing.

    @terryjreedy terryjreedy added the 3.8 only security fixes label Feb 21, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 only security fixes topic-IDLE type-feature A feature request or enhancement
    Projects
    Status: No status
    Development

    No branches or pull requests

    1 participant