Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review extension enable options #66893

Closed
terryjreedy opened this issue Oct 23, 2014 · 2 comments
Closed

Review extension enable options #66893

terryjreedy opened this issue Oct 23, 2014 · 2 comments
Assignees
@terryjreedy
Labels
topic-IDLE type-feature A feature request or enhancement

Comments

@terryjreedy
Copy link
Member

BPO 22704
Nosy @terryjreedy

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2019-02-21.00:21:39.961>
created_at = <Date 2014-10-23.00:17:04.336>
labels = ['expert-IDLE', 'type-feature']
title = 'Review extension enable options'
updated_at = <Date 2019-02-21.00:21:39.960>
user = 'https://github.com/terryjreedy'

bugs.python.org fields:

activity = <Date 2019-02-21.00:21:39.960>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2019-02-21.00:21:39.961>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2014-10-23.00:17:04.336>
creator = 'terry.reedy'
dependencies = []
files = []
hgrepos = []
issue_num = 22704
keywords = []
message_count = 2.0
messages = ['229846', '336161']
nosy_count = 1.0
nosy_names = ['terry.reedy']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue22704'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5']
@terryjreedy
Copy link
Member Author

Currently, each extension is supposed to have an 'enable' option and optionally enable_editor or enable_shell, to "to apply it only to editor/shell windows" (config-extensions.def comment). I think the rule should be changed (see below).

Currently, the file itself does not follow its own rule. Most editor-only options only have enable and not enable_editor. One have enable and enable_shell=False, presumably to exclude the shell, but a user could override False with True, in the user config-extensions, which would not be valid. The file should be changed to follow the current or altered rule.

I think that the requirement should be for the presence of any one of the enable options. An extension that is only valid for the editor should simply have enable_editor. Ditto for enable_shell. Enable by itself would globally turn the extension on or all for all windows, include output windows. It is possible that we might need an enable_output option too.

@terryjreedy terryjreedy self-assigned this Oct 23, 2014
@terryjreedy terryjreedy added topic-IDLE type-feature A feature request or enhancement labels Oct 23, 2014
@terryjreedy
Copy link
Member Author

bpo-27099 converted extensions to features always enabled for when they apply to.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terryjreedy terryjreedy

Labels
topic-IDLE type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@terryjreedy