Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shutil.__all__ incomplete #66855

Closed
vadmium opened this issue Oct 18, 2014 · 7 comments
Closed

shutil.__all__ incomplete #66855

vadmium opened this issue Oct 18, 2014 · 7 comments
Assignees
@berkerpeksag
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@vadmium
Copy link
Member

vadmium commented Oct 18, 2014

BPO 22665
Nosy @merwok, @berkerpeksag, @vadmium
Files
  • issue22665.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/berkerpeksag'
closed_at = <Date 2014-11-01.09:06:37.971>
created_at = <Date 2014-10-18.05:14:13.124>
labels = ['type-bug', 'library']
title = 'shutil.__all__ incomplete'
updated_at = <Date 2014-11-01.09:06:37.969>
user = 'https://github.com/vadmium'

    bugs.python.org fields:

    activity = <Date 2014-11-01.09:06:37.969>
actor = 'berker.peksag'
assignee = 'berker.peksag'
closed = True
closed_date = <Date 2014-11-01.09:06:37.971>
closer = 'berker.peksag'
components = ['Library (Lib)']
creation = <Date 2014-10-18.05:14:13.124>
creator = 'martin.panter'
dependencies = []
files = ['36969']
hgrepos = []
issue_num = 22665
keywords = ['patch']
message_count = 7.0
messages = ['229630', '229684', '229938', '229956', '230439', '230440', '230441']
nosy_count = 4.0
nosy_names = ['eric.araujo', 'python-dev', 'berker.peksag', 'martin.panter']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue22665'
versions = ['Python 3.4', 'Python 3.5']
    @vadmium
    Copy link
    Member Author

    vadmium commented Oct 18, 2014

    Continuing on from bpo-22247 (other out-of-date __all__ attributes), shutil.__all__ is missing (at least) get_terminal_size(), which was implemented for bpo-13609.

    @vadmium vadmium added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Oct 18, 2014
    @berkerpeksag
    Copy link
    Member

    Here is a patch. I also added SameFileError.

    @berkerpeksag berkerpeksag self-assigned this Oct 19, 2014
    @merwok
    Copy link
    Member

    merwok commented Oct 24, 2014

    IIRC test___all__ can be used for this.

    @vadmium
    Copy link
    Member Author

    vadmium commented Oct 24, 2014

    Looking at Lib/test/test___all__.py, that module just makes sure that the names imported with “from ... import *” are the same as listed in the __all__ attribute. It does no know what the __all__ attribute is meant to contain.

    @berkerpeksag
    Copy link
    Member

    I agree with Martin. Plus, this method already used by other tests (see Lib/test/test_nntplib.py and Lib/test/test_warnings.py for example).

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 1, 2014

    New changeset 232520144c6c by Berker Peksag in branch '3.4':
    Issue bpo-22665: Add missing get_terminal_size and SameFileError to shutil.__all__.
    https://hg.python.org/cpython/rev/232520144c6c

    New changeset 193ac288bc7f by Berker Peksag in branch 'default':
    Issue bpo-22665: Add missing get_terminal_size and SameFileError to shutil.__all__.
    https://hg.python.org/cpython/rev/193ac288bc7f

    @berkerpeksag
    Copy link
    Member

    Thanks for the report, Martin.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @berkerpeksag berkerpeksag

    Labels
    stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @berkerpeksag @merwok @vadmium