Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of SRE character tables #66774

Closed
serhiy-storchaka opened this issue Oct 9, 2014 · 3 comments
Closed

Get rid of SRE character tables #66774

serhiy-storchaka opened this issue Oct 9, 2014 · 3 comments
Assignees
@serhiy-storchaka
Labels
extension-modules C modules in the Modules dir topic-regex type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 22584
Nosy @pitrou, @ezio-melotti, @serhiy-storchaka
Files
  • sre_tables.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2014-10-10.08:45:38.731>
created_at = <Date 2014-10-09.07:43:50.471>
labels = ['extension-modules', 'expert-regex', 'type-feature']
title = 'Get rid of SRE character tables'
updated_at = <Date 2014-10-10.08:45:38.729>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2014-10-10.08:45:38.729>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2014-10-10.08:45:38.731>
closer = 'serhiy.storchaka'
components = ['Extension Modules', 'Regular Expressions']
creation = <Date 2014-10-09.07:43:50.471>
creator = 'serhiy.storchaka'
dependencies = []
files = ['36841']
hgrepos = []
issue_num = 22584
keywords = ['patch']
message_count = 3.0
messages = ['228836', '228965', '228970']
nosy_count = 5.0
nosy_names = ['pitrou', 'ezio.melotti', 'mrabarnett', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue22584'
versions = ['Python 3.5']
    @serhiy-storchaka
    Copy link
    Member Author

    Currently the SRE regular expression engine uses internal tables to implement ASCII-only character predicates and converting. Proposed patch get rid of these tables and reuse standard Python macros Py_ISSPACE, Py_TOLOWER, etc.

    @serhiy-storchaka serhiy-storchaka added extension-modules C modules in the Modules dir topic-regex type-feature A feature request or enhancement labels Oct 9, 2014
    @serhiy-storchaka serhiy-storchaka self-assigned this Oct 10, 2014
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 10, 2014

    New changeset 07b7b587837f by Serhiy Storchaka in branch 'default':
    Issue bpo-22584: Got rid of character tables in _sre.c and use standard macros
    https://hg.python.org/cpython/rev/07b7b587837f

    @serhiy-storchaka
    Copy link
    Member Author

    Thank you for your review Antoine.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @serhiy-storchaka serhiy-storchaka

    Labels
    extension-modules C modules in the Modules dir topic-regex type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @serhiy-storchaka