Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BufferedRWpair doesn't clear weakrefs #66707

Closed
pkt mannequin opened this issue Sep 29, 2014 · 5 comments
Closed

BufferedRWpair doesn't clear weakrefs #66707

pkt mannequin opened this issue Sep 29, 2014 · 5 comments
Labels
type-crash A hard crash of the interpreter, possibly with a core dump

Comments

@pkt
Copy link
Mannequin

pkt mannequin commented Sep 29, 2014

BPO 22517
Nosy @pitrou, @benjaminp
Files
  • poc_brwpair_weakref.py
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2014-09-30.02:49:43.337>
created_at = <Date 2014-09-29.20:59:02.155>
labels = ['type-crash']
title = "BufferedRWpair doesn't clear weakrefs"
updated_at = <Date 2014-10-15.12:07:23.733>
user = 'https://bugs.python.org/pkt'

    bugs.python.org fields:

    activity = <Date 2014-10-15.12:07:23.733>
actor = 'pkt'
assignee = 'none'
closed = True
closed_date = <Date 2014-09-30.02:49:43.337>
closer = 'python-dev'
components = []
creation = <Date 2014-09-29.20:59:02.155>
creator = 'pkt'
dependencies = []
files = ['36753']
hgrepos = []
issue_num = 22517
keywords = []
message_count = 5.0
messages = ['227835', '227866', '227905', '227922', '229438']
nosy_count = 6.0
nosy_names = ['pitrou', 'benjamin.peterson', 'stutzbach', 'Arfrever', 'python-dev', 'pkt']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'crash'
url = 'https://bugs.python.org/issue22517'
versions = ['Python 2.7', 'Python 3.3', 'Python 3.4', 'Python 3.5']
    @pkt
    Copy link
    Mannequin Author

    pkt mannequin commented Sep 29, 2014

    # static void
    # bufferedrwpair_dealloc(rwpair *self)
    # {
    # _PyObject_GC_UNTRACK(self);
    # Py_CLEAR(self->reader);
    # Py_CLEAR(self->writer);
    # Py_CLEAR(self->dict);
    # Py_TYPE(self)->tp_free((PyObject *) self);
    # }
    #
    # Weakrefs to this object contain stale pointer after BufferedRWPair is freed.

    @pkt pkt mannequin added the type-crash A hard crash of the interpreter, possibly with a core dump label Sep 29, 2014
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Sep 30, 2014

    New changeset 9b4673d7b046 by Benjamin Peterson in branch '2.7':
    clear BufferedRWPair weakrefs on deallocation (closes bpo-22517)
    https://hg.python.org/cpython/rev/9b4673d7b046

    New changeset e834b32f0422 by Benjamin Peterson in branch '3.3':
    clear BufferedRWPair weakrefs on deallocation (closes bpo-22517)
    https://hg.python.org/cpython/rev/e834b32f0422

    New changeset e54da75100f6 by Benjamin Peterson in branch '3.4':
    merge 3.3 (bpo-22517)
    https://hg.python.org/cpython/rev/e54da75100f6

    New changeset a2add97e28b9 by Benjamin Peterson in branch 'default':
    merge 3.4 (bpo-22517)
    https://hg.python.org/cpython/rev/a2add97e28b9

    @python-dev python-dev mannequin closed this as completed Sep 30, 2014
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Sep 30, 2014

    New changeset 4fa5239624b8 by Georg Brandl in branch '3.2':
    Issue bpo-22517: When a io.BufferedRWPair object is deallocated, clear its
    https://hg.python.org/cpython/rev/4fa5239624b8

    @vstinner vstinner added type-security A security issue and removed type-crash A hard crash of the interpreter, possibly with a core dump labels Sep 30, 2014
    @pitrou
    Copy link
    Member

    pitrou commented Sep 30, 2014

    It's an actual crash, AFAIK.

    @pitrou pitrou added type-crash A hard crash of the interpreter, possibly with a core dump and removed type-security A security issue labels Sep 30, 2014
    @pkt
    Copy link
    Mannequin Author

    pkt mannequin commented Oct 15, 2014

    Why did the type changed from security to crash?

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    type-crash A hard crash of the interpreter, possibly with a core dump
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @pitrou