Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove __version__ string from email #66698

Closed
bitdancer opened this issue Sep 27, 2014 · 6 comments
Closed

Remove __version__ string from email #66698

bitdancer opened this issue Sep 27, 2014 · 6 comments
Labels
topic-email

Comments

@bitdancer
Copy link
Member

BPO 22508
Nosy @warsaw, @bitdancer
Files
  • remove_email_version.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2014-10-03.17:03:33.863>
created_at = <Date 2014-09-27.21:05:22.440>
labels = ['expert-email']
title = 'Remove __version__ string from email'
updated_at = <Date 2015-06-23.21:17:02.603>
user = 'https://github.com/bitdancer'

    bugs.python.org fields:

    activity = <Date 2015-06-23.21:17:02.603>
actor = 'barry'
assignee = 'none'
closed = True
closed_date = <Date 2014-10-03.17:03:33.863>
closer = 'r.david.murray'
components = ['email']
creation = <Date 2014-09-27.21:05:22.440>
creator = 'r.david.murray'
dependencies = []
files = ['36747']
hgrepos = []
issue_num = 22508
keywords = ['patch']
message_count = 6.0
messages = ['227731', '227733', '228331', '228336', '228340', '245701']
nosy_count = 4.0
nosy_names = ['barry', 'r.david.murray', 'tshepang', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue22508'
versions = ['Python 3.5']
    @bitdancer
    Copy link
    Member Author

    There is no longer a concept of a separate 'email' release from the stdlib release. The __version__ string didn't get updated in either 3.3 or 3.4 (my fault). I propose that we simply delete the __version__ variable from __init__.py (patch attached).

    Any objections?

    @warsaw
    Copy link
    Member

    warsaw commented Sep 27, 2014

    On Sep 27, 2014, at 09:05 PM, R. David Murray wrote:

    There is no longer a concept of a separate 'email' release from the stdlib
    release. The __version__ string didn't get updated in either 3.3 or 3.4 (my
    fault). I propose that we simply delete the __version__ variable from
    init.py (patch attached).

    +1

    -Barry

    @tshepang
    Copy link
    Mannequin

    tshepang mannequin commented Oct 3, 2014

    Looks like a safe change. There is only one user in all Debian sources, and it's on Python 2:

    http://codesearch.debian.net/search?q=email.\_\_version__

    @warsaw
    Copy link
    Member

    warsaw commented Oct 3, 2014

    On Oct 03, 2014, at 04:19 PM, Tshepang Lekhonkhobe wrote:

    Looks like a safe change. There is only one user in all Debian sources, and it's on Python 2:

    http://codesearch.debian.net/search?q=email.\_\_version__

    Hahahahahahahaha

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 3, 2014

    New changeset 67f9e757f21b by R David Murray in branch 'default':
    bpo-22508: Drop email __version__ string. It no longer means anything.
    https://hg.python.org/cpython/rev/67f9e757f21b

    @warsaw
    Copy link
    Member

    warsaw commented Jun 23, 2015

    When I ported Mailman 3 to Python 3.5 I had to remove the check on email.__version__ :)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    topic-email
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @warsaw @bitdancer