Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure: Lib/test/test_pydoc.py line 851, "topic?key=def" #66651

Closed
larryhastings opened this issue Sep 22, 2014 · 9 comments
Closed

Test failure: Lib/test/test_pydoc.py line 851, "topic?key=def" #66651

larryhastings opened this issue Sep 22, 2014 · 9 comments
Labels
deferred-blocker type-bug An unexpected behavior, bug, or error

Comments

@larryhastings
Copy link
Contributor

BPO 22461
Nosy @birkenfeld, @larryhastings, @ned-deily, @bitdancer, @zware
Superseder
  • bpo-21431: 3.4.1rc1 test_pydoc fails: pydoc_data.topics.topics values are type "bytes" not "str"
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2014-09-22.18:01:32.653>
created_at = <Date 2014-09-22.13:14:17.661>
labels = ['deferred-blocker', 'type-bug']
title = 'Test failure: Lib/test/test_pydoc.py line 851, "topic?key=def"'
updated_at = <Date 2014-09-23.02:22:33.640>
user = 'https://github.com/larryhastings'

    bugs.python.org fields:

    activity = <Date 2014-09-23.02:22:33.640>
actor = 'berker.peksag'
assignee = 'none'
closed = True
closed_date = <Date 2014-09-22.18:01:32.653>
closer = 'georg.brandl'
components = []
creation = <Date 2014-09-22.13:14:17.661>
creator = 'larry'
dependencies = []
files = []
hgrepos = []
issue_num = 22461
keywords = []
message_count = 9.0
messages = ['227267', '227268', '227270', '227271', '227272', '227286', '227287', '227288', '227289']
nosy_count = 5.0
nosy_names = ['georg.brandl', 'larry', 'ned.deily', 'r.david.murray', 'zach.ware']
pr_nums = []
priority = 'deferred blocker'
resolution = 'duplicate'
stage = 'resolved'
status = 'closed'
superseder = '21431'
type = 'behavior'
url = 'https://bugs.python.org/issue22461'
versions = ['Python 3.4']
    @larryhastings
    Copy link
    Contributor Author

    I get a test failure in the regression test suite. This appears to be the important bit:

        Traceback (most recent call last):
      File "/tmp/Python-3.4.2rc1/Lib/test/test_pydoc.py", line 851, in test_url_requests
        self.assertEqual(result, title, text)
    AssertionError: 'Pydoc: Error - topic?key=def' != 'Pydoc: KEYWORD def'
    - Pydoc: Error - topic?key=def
    + Pydoc: KEYWORD def

    I can ship 3.4.2rc1 like this, but I'd really like this fixed before 3.4.2 final.

    Does anybody own pydoc? There's no "expert" listed on the Python Experts page.

    (Adding you, Georg, because you're the DE.)

    @larryhastings larryhastings added deferred-blocker type-bug An unexpected behavior, bug, or error labels Sep 22, 2014
    @birkenfeld
    Copy link
    Member

    I have no idea about that code, and I can't reproduce the failure.

    (Could the buildbots?)

    @bitdancer
    Copy link
    Member

    I can't reproduce it either, and none of the failing stable buildbots show this error. Unfortunately we can only look at tip since we can't see your tag yet. But I doubt that's the issue...the last commit to pydoc or its tests was on the 17th, and was a one line change in an unrelated area. Last change before that was in June.

    @larryhastings
    Copy link
    Contributor Author

    FWIW, 3.4.2rc1 is based on 7af0315bdfe0. (The release process creates a couple additional changesets.)

    The failure is on my laptop, Ubuntu 14.04 x64.

    @bitdancer
    Copy link
    Member

    No failure running test_pydoc for me on gentoo linux with that changeset.

    @zware
    Copy link
    Member

    zware commented Sep 22, 2014

    R. David Murray wrote (on python-committers):

    So...Larry broke it, but it is not obvious how. Could it be something
    wrong with the pydoc topics update for the release?

    Indeed, it looks like somehow the pydoc-topics update turned all of the values in the topics dict into bytes literals rather than plain strings.

    Unfortunately, I don't have the right setup currently to look into it further, but my best guess would be that perhaps the pydoc-topics Sphinx builder needs an update for Python 3?

    @birkenfeld
    Copy link
    Member

    That is very likely the reason. So far nobody has run the builder with Python 3.

    @ned-deily
    Copy link
    Member

    Duplicate of bpo-21431?

    @birkenfeld
    Copy link
    Member

    Yep.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    deferred-blocker type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    5 participants
    @birkenfeld @bitdancer @ned-deily @zware @larryhastings