Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools/msi enhancements for 2.7 #66592

Closed
zooba opened this issue Sep 12, 2014 · 4 comments
Closed

Tools/msi enhancements for 2.7 #66592

zooba opened this issue Sep 12, 2014 · 4 comments
Assignees
@zooba
Labels
OS-windows topic-installation type-feature A feature request or enhancement

Comments

@zooba
Copy link
Member

zooba commented Sep 12, 2014

BPO 22398
Nosy @pitrou, @tjguk, @zware, @zooba
Files
  • Tool_msi_27.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
closed_at = <Date 2014-09-12.20:19:18.942>
created_at = <Date 2014-09-12.18:46:13.222>
labels = ['type-feature', 'expert-installation', 'OS-windows']
title = 'Tools/msi enhancements for 2.7'
updated_at = <Date 2014-09-13.16:17:03.030>
user = 'https://github.com/zooba'

    bugs.python.org fields:

    activity = <Date 2014-09-13.16:17:03.030>
actor = 'berker.peksag'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2014-09-12.20:19:18.942>
closer = 'steve.dower'
components = ['Installation', 'Windows']
creation = <Date 2014-09-12.18:46:13.222>
creator = 'steve.dower'
dependencies = []
files = ['36613']
hgrepos = []
issue_num = 22398
keywords = ['patch']
message_count = 4.0
messages = ['226839', '226842', '226843', '226844']
nosy_count = 5.0
nosy_names = ['pitrou', 'tim.golden', 'python-dev', 'zach.ware', 'steve.dower']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue22398'
versions = ['Python 2.7']
    @zooba
    Copy link
    Member Author

    zooba commented Sep 12, 2014

    This patch has some minor changes to the build scripts for Python 2.7 on Windows. They're fully tested on my build machine, but I wanted someone who's more familiar with how the buildbots are set up to either confirm that the Tools/msi scripts are not used or that the changes won't have an impact.

    The Tools/msi/msi.py changes to use environment variables are mostly to make my life easier. Apparently the old way was to actually modify the file before making an official release...

    The Tools/msi/msilib.py fix is necessary because of some new files that were added for 2.7.9. Technically it's a release blocker, though it won't actually hold anything up since I spotted it.

    @zooba zooba self-assigned this Sep 12, 2014
    @zooba zooba added topic-installation OS-windows type-feature A feature request or enhancement labels Sep 12, 2014
    @zware
    Copy link
    Member

    zware commented Sep 12, 2014

    Actually, I think the method Martin used was to create a local config.py in Tools/msi/, which provided the proper settings for the release. See http://hg.python.org/cpython/file/2.7/Tools/msi/msi.py#l37

    Either way, the buildbots are completely unaffected by Tools/msi, and I don't think anything actually uses PCbuild/build_tkinter.py (unless you do :)), so since the script is now yours, I'd say you're clear to change as you like.

    @zooba
    Copy link
    Member Author

    zooba commented Sep 12, 2014

    Thanks for confirming. Somehow I never noticed the import config line - guess that's a pattern I'm not really used to seeing. Still, I prefer having the env variables there as I invoke the scripts through some batch files (very specific to my machine, unfortunately, but the 3.5 ones will be more generic).

    And since you mention it, apparently I'm not using build_tkinter.py any more either. I was at one point, hence the fix. I'll leave it in there - we can probably remove the file completely but no harm in leaving it.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Sep 12, 2014

    New changeset 5c55a7bfec0c by Steve Dower in branch '2.7':
    bpo-22398 Tools/msi enhancements for 2.7
    http://hg.python.org/cpython/rev/5c55a7bfec0c

    @zooba zooba closed this as completed Sep 12, 2014
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zooba zooba

    Labels
    OS-windows topic-installation type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @zooba @zware