Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lib2to3.tests and test_lib2to3 to use test discovery #66369

Closed
zware opened this issue Aug 8, 2014 · 4 comments
Closed

Update lib2to3.tests and test_lib2to3 to use test discovery #66369

zware opened this issue Aug 8, 2014 · 4 comments
Assignees
@zware
Labels
tests Tests in the Lib/test dir topic-2to3 type-bug An unexpected behavior, bug, or error

Comments

@zware
Copy link
Member

zware commented Aug 8, 2014

BPO 22173
Nosy @ezio-melotti, @zware
Files
  • test_lib2to3_discovery.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zware'
closed_at = <Date 2014-10-29.17:28:47.882>
created_at = <Date 2014-08-08.14:08:01.426>
labels = ['tests', 'type-bug', 'expert-2to3']
title = 'Update lib2to3.tests and test_lib2to3 to use test discovery'
updated_at = <Date 2014-10-29.17:30:14.923>
user = 'https://github.com/zware'

    bugs.python.org fields:

    activity = <Date 2014-10-29.17:30:14.923>
actor = 'zach.ware'
assignee = 'zach.ware'
closed = True
closed_date = <Date 2014-10-29.17:28:47.882>
closer = 'python-dev'
components = ['Tests', '2to3 (2.x to 3.x conversion tool)']
creation = <Date 2014-08-08.14:08:01.426>
creator = 'zach.ware'
dependencies = []
files = ['36311']
hgrepos = []
issue_num = 22173
keywords = ['patch']
message_count = 4.0
messages = ['225072', '230130', '230228', '230229']
nosy_count = 3.0
nosy_names = ['ezio.melotti', 'python-dev', 'zach.ware']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue22173'
versions = ['Python 3.4', 'Python 3.5']
    @zware
    Copy link
    Member Author

    zware commented Aug 8, 2014

    The attached patch updates lib2to3.tests and the test.test_lib2to3 script to use test discovery. It also re-enables lib2to3.tests.test_all_fixers with a "cpu" resource guard. That test has been failing since at least 3.2, but was never run anyway. To allow it to pass, the patch adds "from __future__ import print_function" to lib2to3.main and lib2to3.tests.pytree_idempotency.

    @zware zware added tests Tests in the Lib/test dir topic-2to3 type-bug An unexpected behavior, bug, or error labels Aug 8, 2014
    @ezio-melotti
    Copy link
    Member

    LGTM

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 29, 2014

    New changeset 9d36bf887be3 by Zachary Ware in branch '3.4':
    Issue bpo-22173: Update lib2to3 tests to use unittest test discovery.
    https://hg.python.org/cpython/rev/9d36bf887be3

    New changeset 179ccc48566f by Zachary Ware in branch 'default':
    Closes bpo-22173: Merge with 3.4
    https://hg.python.org/cpython/rev/179ccc48566f

    @python-dev python-dev mannequin closed this as completed Oct 29, 2014
    @zware
    Copy link
    Member Author

    zware commented Oct 29, 2014

    Thanks, Ezio!

    @zware zware self-assigned this Oct 29, 2014
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zware zware

    Labels
    tests Tests in the Lib/test dir topic-2to3 type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @zware @ezio-melotti