Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Idle configDialog: fix regression and add minimal unittest #66181

Closed
SaimadhavHeblikar mannequin opened this issue Jul 14, 2014 · 3 comments
Closed

Idle configDialog: fix regression and add minimal unittest #66181

SaimadhavHeblikar mannequin opened this issue Jul 14, 2014 · 3 comments
Assignees
@terryjreedy
Labels
topic-IDLE type-crash A hard crash of the interpreter, possibly with a core dump

Comments

@SaimadhavHeblikar
Copy link
Mannequin

SaimadhavHeblikar mannequin commented Jul 14, 2014

BPO 21982
Nosy @terryjreedy

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2014-07-15.03:20:39.676>
created_at = <Date 2014-07-14.14:43:31.753>
labels = ['expert-IDLE', 'type-crash']
title = 'Idle configDialog: fix regression and add minimal unittest'
updated_at = <Date 2019-03-23.20:05:59.074>
user = 'https://bugs.python.org/SaimadhavHeblikar'

bugs.python.org fields:

activity = <Date 2019-03-23.20:05:59.074>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2014-07-15.03:20:39.676>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2014-07-14.14:43:31.753>
creator = 'Saimadhav.Heblikar'
dependencies = []
files = []
hgrepos = []
issue_num = 21982
keywords = []
message_count = 3.0
messages = ['223031', '223079', '223081']
nosy_count = 3.0
nosy_names = ['terry.reedy', 'python-dev', 'Saimadhav.Heblikar']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'crash'
url = 'https://bugs.python.org/issue21982'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5']
@SaimadhavHeblikar
Copy link
Mannequin Author

SaimadhavHeblikar mannequin commented Jul 14, 2014

The concerned part : http://hg.python.org/cpython/rev/b836a0cd68f7#l4.15

"NameError: name 'keySet' is not defined."

@SaimadhavHeblikar SaimadhavHeblikar mannequin added the type-crash A hard crash of the interpreter, possibly with a core dump label Jul 14, 2014
@python-dev
Copy link
Mannequin

python-dev mannequin commented Jul 15, 2014

New changeset af1351800c7a by Terry Jan Reedy in branch '2.7':
Issue bpo-21982: Add minimal unittest for configDialog with 46% coverage.
http://hg.python.org/cpython/rev/af1351800c7a

New changeset 681979c6e6b2 by Terry Jan Reedy in branch '3.4':
Issue bpo-21982: Add minimal unittest for configDialog with 46% coverage.
http://hg.python.org/cpython/rev/681979c6e6b2

@terryjreedy
Copy link
Member

Thanks for catching this. Either I misread pyflakes output or it has a bug. In either case, I should have searched this one like I did some others. The htest caught this. I added a minimal unittest that initially failed, covers half the module, and now passes.

2.7 did not have the error, but the rest of the changes apply.

---
More info on a recurring 'nuisance': Start Idle on Windows from debug build interpreter. After ConfigDialog(), test termination causes the following to be printed in the interpreter window.

can't invoke "event" command: application has been destroyed
while executing
"event generate $w <<ThemeChanged>>"
(procedure "ttk::ThemeChanged" line 6)
invoked from within
"ttk::ThemeChanged"

This happens *after* tearDownClass runs. I determined this by adding
def tearDownModule(): input('mod') to pause. Changing to "d = ConfigDialog(...); d.destroy()" has no effect. Commenting out parts of dialog construction might narrow down the responsible component.

@terryjreedy terryjreedy changed the title Idle: Regression introduced in configDialog by rev 91509 Idle configDialog: fix regression and add minimal unittest Jul 15, 2014
@terryjreedy terryjreedy self-assigned this Mar 23, 2019
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terryjreedy terryjreedy

Labels
topic-IDLE type-crash A hard crash of the interpreter, possibly with a core dump
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@terryjreedy