Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_ssl.py to handle LibreSSL versioning appropriately #66175

Closed
worr mannequin opened this issue Jul 14, 2014 · 5 comments
Closed

Fix test_ssl.py to handle LibreSSL versioning appropriately #66175

worr mannequin opened this issue Jul 14, 2014 · 5 comments
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@worr
Copy link
Mannequin

worr mannequin commented Jul 14, 2014

BPO 21976
Nosy @pitrou, @giampaolo, @tiran, @dstufft, @worr
Files
  • libressl-tests.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2014-07-21.22:41:03.891>
created_at = <Date 2014-07-14.06:15:58.381>
labels = ['type-bug', 'tests']
title = 'Fix test_ssl.py to handle LibreSSL versioning appropriately'
updated_at = <Date 2014-07-21.22:41:03.890>
user = 'https://github.com/worr'

    bugs.python.org fields:

    activity = <Date 2014-07-21.22:41:03.890>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2014-07-21.22:41:03.891>
closer = 'pitrou'
components = ['Tests']
creation = <Date 2014-07-14.06:15:58.381>
creator = 'worr'
dependencies = []
files = ['35949']
hgrepos = []
issue_num = 21976
keywords = ['patch']
message_count = 5.0
messages = ['222996', '223067', '223614', '223615', '223616']
nosy_count = 6.0
nosy_names = ['pitrou', 'giampaolo.rodola', 'christian.heimes', 'python-dev', 'dstufft', 'worr']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue21976'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5']
    @worr
    Copy link
    Mannequin Author

    worr mannequin commented Jul 14, 2014

    Currently, test_ssl.py requires the version information to match the OpenSSL format exactly, and to be less than 2.0. LibreSSL, a drop-in replacement for OpenSSL, has started its version numbers at 2.0.0, and reports it slightly differently. This patch addresses that.

    Tested on Exherbo Linux amd64 with LibreSSL portable 2.0.1.

    @worr worr mannequin added tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Jul 14, 2014
    @pitrou
    Copy link
    Member

    pitrou commented Jul 14, 2014

    I don't have LibreSSL to test but the patch sounds fine to me.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jul 21, 2014

    New changeset 4dac45f88d45 by Antoine Pitrou in branch '3.4':
    Issue bpo-21976: Fix test_ssl to accept LibreSSL version strings.
    http://hg.python.org/cpython/rev/4dac45f88d45

    New changeset 98aec1d9e2a0 by Antoine Pitrou in branch 'default':
    Issue bpo-21976: Fix test_ssl to accept LibreSSL version strings.
    http://hg.python.org/cpython/rev/98aec1d9e2a0

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jul 21, 2014

    New changeset 33fc081285b2 by Antoine Pitrou in branch '2.7':
    Issue bpo-21976: Fix test_ssl to accept LibreSSL version strings.
    http://hg.python.org/cpython/rev/33fc081285b2

    @pitrou
    Copy link
    Member

    pitrou commented Jul 21, 2014

    This should be fixed now. Thank you very much!

    @pitrou pitrou closed this as completed Jul 21, 2014
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @pitrou