Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert test_tools to directory #66117

Closed
serhiy-storchaka opened this issue Jul 4, 2014 · 9 comments
Closed

Convert test_tools to directory #66117

serhiy-storchaka opened this issue Jul 4, 2014 · 9 comments
Assignees
@zware
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 21918
Nosy @berkerpeksag, @zware, @serhiy-storchaka
Files
  • test_tools.diff: Patch against default
  • test_tools.diff--git: Patch against default, --git format
  • test_tools.v2.diff--git
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zware'
closed_at = <Date 2014-07-16.19:37:02.174>
created_at = <Date 2014-07-04.18:48:13.252>
labels = ['type-feature', 'tests']
title = 'Convert test_tools to directory'
updated_at = <Date 2014-07-16.21:17:33.437>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2014-07-16.21:17:33.437>
actor = 'zach.ware'
assignee = 'zach.ware'
closed = True
closed_date = <Date 2014-07-16.19:37:02.174>
closer = 'zach.ware'
components = ['Tests']
creation = <Date 2014-07-04.18:48:13.252>
creator = 'serhiy.storchaka'
dependencies = []
files = ['35905', '35906', '35957']
hgrepos = []
issue_num = 21918
keywords = ['patch']
message_count = 9.0
messages = ['222305', '222579', '222580', '223136', '223143', '223258', '223259', '223277', '223279']
nosy_count = 4.0
nosy_names = ['python-dev', 'berker.peksag', 'zach.ware', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue21918'
versions = ['Python 3.4', 'Python 3.5']
    @serhiy-storchaka
    Copy link
    Member Author

    Lib/test/test_tools.py becomes too large. It includes tests of unrelated command-lines tools and scripts. It would be good to convert it to directory containing separate test files for different tools.

    @serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir type-feature A feature request or enhancement labels Jul 4, 2014
    @zware
    Copy link
    Member

    zware commented Jul 8, 2014

    How about this?

    @zware
    Copy link
    Member

    zware commented Jul 8, 2014

    Here's the same patch in --git format, which should make the actual changes clearer (though probably not in Rietveld).

    @zware
    Copy link
    Member

    zware commented Jul 15, 2014

    Here's a new version of the patch in response to review comments. Patch is in --git format, which means no Rietveld link for this one.

    Changes from the first patch:

    @serhiy-storchaka
    Copy link
    Member Author

    About load_tests() -- look at Lib/test/test_email/init.py.

    Otherwise LGTM.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jul 16, 2014

    New changeset e69f037332a6 by Zachary Ware in branch '3.4':
    Issue bpo-21918: Convert test_tools.py to a sub-package of test.
    http://hg.python.org/cpython/rev/e69f037332a6

    New changeset 1d0ca204c36f by Zachary Ware in branch 'default':
    Issue bpo-21918: Convert test_tools.py to a sub-package of test.
    http://hg.python.org/cpython/rev/1d0ca204c36f

    @zware
    Copy link
    Member

    zware commented Jul 16, 2014

    Committed, thanks for the reviews!

    I had modeled load_tests after test_json's load_tests. The idiom used in test_email causes a warning from regrtest about sys.path being modified, so I modified the idiom slightly and used that. I have declined to backport the patch to 2.7; it's more trouble than it's worth to me.

    @zware zware closed this as completed Jul 16, 2014
    @serhiy-storchaka
    Copy link
    Member Author

    Thanks for your patch. Do you want to correct test_json's and others
    load_tests?

    @zware
    Copy link
    Member

    zware commented Jul 16, 2014

    Sure, I'll work on that some time this week.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zware zware

    Labels
    tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @serhiy-storchaka @zware