Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create unit tests for turtle textonly #66115

Closed
ingrid mannequin opened this issue Jul 4, 2014 · 23 comments
Closed

Create unit tests for turtle textonly #66115

ingrid mannequin opened this issue Jul 4, 2014 · 23 comments
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@ingrid
Copy link
Mannequin

ingrid mannequin commented Jul 4, 2014

BPO 21916
Nosy @tjguk, @bitdancer, @serhiy-storchaka, @JelleZijlstra
Files
  • test_turtle_textonly.patch
  • test_turtle_textonly.patch
  • test_turtle.patch
  • test_turtle.patch
  • issue21916-cr.patch: new patch adding test_turtle.py
  • issue21916-cr2.patch
  • issue21916-more.patch: patch with more Vec2D tests
  • issue21916-more-cr.patch: patch addressing code review comments
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2016-06-05.07:39:19.542>
created_at = <Date 2014-07-04.13:12:44.626>
labels = ['type-feature', 'tests']
title = 'Create unit tests for turtle textonly'
updated_at = <Date 2016-06-05.07:39:19.541>
user = 'https://bugs.python.org/ingrid'

    bugs.python.org fields:

    activity = <Date 2016-06-05.07:39:19.541>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2016-06-05.07:39:19.542>
closer = 'serhiy.storchaka'
components = ['Tests']
creation = <Date 2014-07-04.13:12:44.626>
creator = 'ingrid'
dependencies = []
files = ['35856', '38950', '39018', '39458', '43199', '43202', '43216', '43228']
hgrepos = []
issue_num = 21916
keywords = ['patch', 'needs review']
message_count = 23.0
messages = ['222282', '240726', '240832', '241014', '243774', '243775', '243776', '243778', '243779', '243781', '243786', '267271', '267289', '267290', '267312', '267314', '267315', '267332', '267349', '267378', '267387', '267397', '267398']
nosy_count = 9.0
nosy_names = ['tim.golden', 'r.david.murray', 'jesstess', 'python-dev', 'serhiy.storchaka', 'ingrid', 'arachnegl', 'gregoryloyse@gmail.com', 'JelleZijlstra']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue21916'
versions = ['Python 2.7', 'Python 3.5', 'Python 3.6']
    @ingrid
    Copy link
    Mannequin Author

    ingrid mannequin commented Jul 4, 2014

    Non-gui tests for turtle that Lita and I wrote.

    @ingrid ingrid mannequin added the tests Tests in the Lib/test dir label Jul 4, 2014
    @arachnegl
    Copy link
    Mannequin

    arachnegl mannequin commented Apr 13, 2015

    Patch reviewed. Looks good.

    This patch includes some amendments for readablity and new tests.

    @bitdancer
    Copy link
    Member

    I made some review comments on ways to use test.support and test.subTest to simplify the code and make it even clearer. Also, I suggest not using Mock unless necessary (see review comments).

    @arachnegl
    Copy link
    Mannequin

    arachnegl mannequin commented Apr 14, 2015

    Thanks David for your review!

    I have added a new patch in response.

    Note the file has a new name

    @tjguk
    Copy link
    Member

    tjguk commented May 21, 2015

    Tests failed on Windows probably because of NamedTemporaryFile

    @gregoryloysegmailcom
    Copy link
    Mannequin

    gregoryloysegmailcom mannequin commented May 21, 2015

    Thanks Tim for testing on Windows and suggesting the change.

    @tjguk
    Copy link
    Member

    tjguk commented May 21, 2015

    @rdm I'm sitting with Greg at a London Python session and we've run through these tests on 3.4/3.5. I know you were reviewing this code at PyCon. Are you happy for me to commit from here?

    @serhiy-storchaka
    Copy link
    Member

    I'm making a review.

    @bitdancer
    Copy link
    Member

    Yes, I don't need to be involved further (unless you need help from me on something :)

    @tjguk
    Copy link
    Member

    tjguk commented May 21, 2015

    Serhiy's offered a review and we can take it from here. :)

    @serhiy-storchaka
    Copy link
    Member

    Added comments on Rietveld.

    It looks the patch includes changes for non-relevant files.

    @serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label May 21, 2015
    @JelleZijlstra
    Copy link
    Member

    This patch removes the unrelated XML changes and addresses most of the code review comments.

    @serhiy-storchaka
    Copy link
    Member

    Added few minor comments on Rietveld. Please use more complex example for invalid config. Add valid lines before and after an invalid line.

    @JelleZijlstra
    Copy link
    Member

    Thanks for your comments. Added a patch addressing your comments.

    @serhiy-storchaka
    Copy link
    Member

    Nice. LGTM.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jun 4, 2016

    New changeset f0b94cfcea45 by Serhiy Storchaka in branch '2.7':
    Issue bpo-21916: Added tests for the turtle module.
    https://hg.python.org/cpython/rev/f0b94cfcea45

    New changeset 3b9e96440a70 by Serhiy Storchaka in branch '3.5':
    Issue bpo-21916: Added tests for the turtle module.
    https://hg.python.org/cpython/rev/3b9e96440a70

    New changeset 3d1a23984a6e by Serhiy Storchaka in branch 'default':
    Issue bpo-21916: Added tests for the turtle module.
    https://hg.python.org/cpython/rev/3d1a23984a6e

    @serhiy-storchaka
    Copy link
    Member

    Jelle, do you want to add tests the constructor, repr and pickling of Vec2D?

    @JelleZijlstra
    Copy link
    Member

    Thanks for merging it in. I'll add the additional tests.

    @JelleZijlstra
    Copy link
    Member

    Patch tests constructor, repr, equality checks, and pickling on Vec2D.

    @serhiy-storchaka
    Copy link
    Member

    Thank you Jelle. Added minor comments on Rietveld.

    @JelleZijlstra
    Copy link
    Member

    Thanks, this patch addresses your comments.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jun 5, 2016

    New changeset 5c1befa401ca by Serhiy Storchaka in branch '3.5':
    Issue bpo-21916: Added more tests for the turtle module.
    https://hg.python.org/cpython/rev/5c1befa401ca

    New changeset 41fa38ea46ba by Serhiy Storchaka in branch '2.7':
    Issue bpo-21916: Added more tests for the turtle module.
    https://hg.python.org/cpython/rev/41fa38ea46ba

    New changeset 356f411e8c5c by Serhiy Storchaka in branch 'default':
    Issue bpo-21916: Added more tests for the turtle module.
    https://hg.python.org/cpython/rev/356f411e8c5c

    @serhiy-storchaka
    Copy link
    Member

    Thank you for your patches Jelle.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @bitdancer @tjguk @JelleZijlstra @serhiy-storchaka