Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make _ssl module 64-bit clean #65980

Closed
vstinner opened this issue Jun 16, 2014 · 7 comments
Closed

make _ssl module 64-bit clean #65980

vstinner opened this issue Jun 16, 2014 · 7 comments
Labels
type-bug An unexpected behavior, bug, or error

Comments

@vstinner
Copy link
Member

BPO 21781
Nosy @vstinner, @zware
Files
  • ssl_64bit.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2014-07-07.20:29:14.189>
created_at = <Date 2014-06-16.16:18:56.914>
labels = ['type-bug']
title = 'make _ssl module 64-bit clean'
updated_at = <Date 2014-07-07.20:29:14.188>
user = 'https://github.com/vstinner'

    bugs.python.org fields:

    activity = <Date 2014-07-07.20:29:14.188>
actor = 'zach.ware'
assignee = 'none'
closed = True
closed_date = <Date 2014-07-07.20:29:14.189>
closer = 'zach.ware'
components = []
creation = <Date 2014-06-16.16:18:56.914>
creator = 'vstinner'
dependencies = []
files = ['35658']
hgrepos = []
issue_num = 21781
keywords = ['patch']
message_count = 7.0
messages = ['220736', '222037', '222038', '222475', '222505', '222506', '222512']
nosy_count = 3.0
nosy_names = ['vstinner', 'python-dev', 'zach.ware']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue21781'
versions = ['Python 3.4', 'Python 3.5']
    @vstinner
    Copy link
    Member Author

    Follow-up of issue bpo-8677: patch to make the _ssl module 64-bit clean.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jul 1, 2014

    New changeset 36e884e65e45 by Victor Stinner in branch '3.4':
    Issue bpo-21781: Make the ssl module "ssize_t clean" for parsing parameters.
    http://hg.python.org/cpython/rev/36e884e65e45

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jul 1, 2014

    New changeset 26afcb8a87b9 by Victor Stinner in branch 'default':
    (Merge 3.4) Issue bpo-21781: Make the ssl module "ssize_t clean" for parsing
    http://hg.python.org/cpython/rev/26afcb8a87b9

    @vstinner vstinner closed this as completed Jul 1, 2014
    @zware
    Copy link
    Member

    zware commented Jul 7, 2014

    This appears to have broken 64-bit Windows:

    http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/4745

    @zware zware reopened this Jul 7, 2014
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jul 7, 2014

    New changeset 34a0d98c51ea by Victor Stinner in branch '3.4':
    Issue bpo-21781, _ssl: Fix asn1obj2py() on Windows 64-bit, "s#" format requires
    http://hg.python.org/cpython/rev/34a0d98c51ea

    New changeset 1dca2e7ad5ad by Victor Stinner in branch 'default':
    (Merge 3.4) Issue bpo-21781, _ssl: Fix asn1obj2py() on Windows 64-bit, "s#" format
    http://hg.python.org/cpython/rev/1dca2e7ad5ad

    @vstinner
    Copy link
    Member Author

    vstinner commented Jul 7, 2014

    This appears to have broken 64-bit Windows

    Correct, I missed a call to Py_BuildValue() which uses the s# format. It's now fixed. Thanks for the report!

    I keep the issue open until the buildbot turns green again.

    @zware
    Copy link
    Member

    zware commented Jul 7, 2014

    Looks good now, thanks for the quick fix, Victor!

    @zware zware closed this as completed Jul 7, 2014
    @zware zware added the type-bug An unexpected behavior, bug, or error label Jul 7, 2014
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @zware