Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove site-python support #65910

Closed
pitrou opened this issue Jun 10, 2014 · 5 comments
Closed

Remove site-python support #65910

pitrou opened this issue Jun 10, 2014 · 5 comments
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@pitrou
Copy link
Member

pitrou commented Jun 10, 2014

BPO 21711
Nosy @pitrou, @tjguk, @ned-deily, @zware, @zooba
Files
  • sitepython.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2014-06-12.23:42:03.280>
created_at = <Date 2014-06-10.23:44:40.270>
labels = ['type-feature', 'library']
title = 'Remove site-python support'
updated_at = <Date 2014-06-12.23:42:03.279>
user = 'https://github.com/pitrou'

    bugs.python.org fields:

    activity = <Date 2014-06-12.23:42:03.279>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2014-06-12.23:42:03.280>
closer = 'pitrou'
components = ['Library (Lib)']
creation = <Date 2014-06-10.23:44:40.270>
creator = 'pitrou'
dependencies = []
files = ['35561']
hgrepos = []
issue_num = 21711
keywords = ['patch']
message_count = 5.0
messages = ['220214', '220217', '220290', '220294', '220398']
nosy_count = 6.0
nosy_names = ['pitrou', 'tim.golden', 'ned.deily', 'python-dev', 'zach.ware', 'steve.dower']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue21711'
versions = ['Python 3.5']
    @pitrou
    Copy link
    Member Author

    pitrou commented Jun 10, 2014

    Support for "site-python" directories in site.py was deprecated in 3.4 and slated for removal in 3.5. Attached patch does the remove.

    @pitrou pitrou added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Jun 10, 2014
    @ned-deily
    Copy link
    Member

    The patch has one problem with OS X framework builds. This fixes it:

    --- a/Lib/test/test_site.py
+++ b/Lib/test/test_site.py
@@ -240,7 +240,7 @@
                                   sysconfig.get_config_var("PYTHONFRAMEWORK"),
                                   sys.version[:3],
                                   'site-packages')
-            self.assertEqual(dirs[2], wanted)
+            self.assertEqual(dirs[1], wanted)
         elif os.sep == '/':
             # OS X non-framwework builds, Linux, FreeBSD, etc
             self.assertEqual(len(dirs), 1)

    Otherwise, LGTM

    @pitrou
    Copy link
    Member Author

    pitrou commented Jun 11, 2014

    Thanks Ned, I'm hoping someone can give it a run under Windows too :)

    @zware
    Copy link
    Member

    zware commented Jun 11, 2014

    Seems fine on Windows (especially since it doesn't look like site-python ever meant anything on Windows in the first place)!

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jun 12, 2014

    New changeset 3852afce2ca3 by Antoine Pitrou in branch 'default':
    Issue bpo-21711: support for "site-python" directories has now been removed from the site module (it was deprecated in 3.4).
    http://hg.python.org/cpython/rev/3852afce2ca3

    @pitrou pitrou closed this as completed Jun 12, 2014
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @pitrou @ned-deily @zware