Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDLE - Test Replace Dialog #65875

Closed
SaimadhavHeblikar mannequin opened this issue Jun 6, 2014 · 3 comments
Closed

IDLE - Test Replace Dialog #65875

SaimadhavHeblikar mannequin opened this issue Jun 6, 2014 · 3 comments
Assignees
@terryjreedy
Labels
topic-IDLE type-feature A feature request or enhancement

Comments

@SaimadhavHeblikar
Copy link
Mannequin

SaimadhavHeblikar mannequin commented Jun 6, 2014

BPO 21676
Nosy @terryjreedy
Files
  • test-replace-34.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2016-05-18.00:05:50.997>
created_at = <Date 2014-06-06.06:36:35.223>
labels = ['expert-IDLE', 'type-feature']
title = 'IDLE - Test Replace Dialog'
updated_at = <Date 2016-05-18.00:05:50.994>
user = 'https://bugs.python.org/SaimadhavHeblikar'

    bugs.python.org fields:

    activity = <Date 2016-05-18.00:05:50.994>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2016-05-18.00:05:50.997>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2014-06-06.06:36:35.223>
creator = 'Saimadhav.Heblikar'
dependencies = []
files = ['35493']
hgrepos = []
issue_num = 21676
keywords = ['patch']
message_count = 3.0
messages = ['219863', '265792', '265794']
nosy_count = 4.0
nosy_names = ['terry.reedy', 'jesstess', 'python-dev', 'Saimadhav.Heblikar']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue21676'
versions = ['Python 3.5', 'Python 3.6']
    @SaimadhavHeblikar
    Copy link
    Mannequin Author

    SaimadhavHeblikar mannequin commented Jun 6, 2014

    Add unittest for idlelib's replace dialog.
    7 lines related to replacedialog logic could not be tested. Any input on how to test those lines?

    Running the test suite for idlelib emits:
    "ttk::ThemeChanged"
    invalid command name "3069198412callit"
    while executing
    "3069198412callit"
    ("after" script)
    invalid command name "3051229868callit"
    while executing
    "3051229868callit"
    ("after" script),

    though the tests pass.

    If this is fine, will post a 2.7 backport.

    @SaimadhavHeblikar SaimadhavHeblikar mannequin added the topic-IDLE label Jun 6, 2014
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented May 17, 2016

    New changeset d8ed90a35505 by Terry Jan Reedy in branch '3.5':
    Issue bpo-21676: test IDLE replace dialog. Original patch by Saimadhav Heblikar.
    https://hg.python.org/cpython/rev/d8ed90a35505

    @terryjreedy
    Copy link
    Member

    The 'Theme changed' message is maddening. I verified that is was not occurring without this patch. I made sure all widgets were passed cls.root as master, and that all were delected. Running the class with "def test_dummy(self): pass" and all other methods commented out did not result in the message. So setup and teardown do not, in themselves, cause it. Running the first test, test_simple up to the point where a replace function is caused did not trigger the message. Running most any replace funcition does trigger. The base dialog and search tests do not trigger, so merely creating an engine did not. One new thing in replace test is tests using REs.

    Anyway, pushed slightly modified files. I am no longer backporting 'routine' patches to 2.7.

    @terryjreedy terryjreedy self-assigned this May 18, 2016
    @terryjreedy terryjreedy added the type-feature A feature request or enhancement label May 18, 2016
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @terryjreedy terryjreedy

    Labels
    topic-IDLE type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @terryjreedy