Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tkinter tests #65721

Closed
serhiy-storchaka opened this issue May 18, 2014 · 6 comments
Closed

Add more tkinter tests #65721

serhiy-storchaka opened this issue May 18, 2014 · 6 comments
Assignees
@serhiy-storchaka
Labels
tests Tests in the Lib/test dir topic-tkinter type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 21522
Nosy @ned-deily, @serhiy-storchaka
Files
  • test_tkinter_configure.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2014-05-24.04:43:24.204>
created_at = <Date 2014-05-18.12:25:58.997>
labels = ['tests', 'type-feature', 'expert-tkinter']
title = 'Add more tkinter tests'
updated_at = <Date 2014-05-24.04:43:24.203>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2014-05-24.04:43:24.203>
actor = 'ned.deily'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2014-05-24.04:43:24.204>
closer = 'ned.deily'
components = ['Tests', 'Tkinter']
creation = <Date 2014-05-18.12:25:58.997>
creator = 'serhiy.storchaka'
dependencies = []
files = ['35278']
hgrepos = []
issue_num = 21522
keywords = ['patch']
message_count = 6.0
messages = ['218741', '218959', '218989', '218997', '219001', '219023']
nosy_count = 3.0
nosy_names = ['ned.deily', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue21522'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5']
    @serhiy-storchaka
    Copy link
    Member Author

    Here is a patch which adds tests for Listbox.itemconfigure(), PanedWindow.paneconfigure() and several tests for Menu.entryconfigure().

    @serhiy-storchaka serhiy-storchaka self-assigned this May 18, 2014
    @serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir topic-tkinter type-feature A feature request or enhancement labels May 18, 2014
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented May 23, 2014

    New changeset a7082e2898aa by Serhiy Storchaka in branch '2.7':
    Issue bpo-21522: Added Tkinter tests for Listbox.itemconfigure(),
    http://hg.python.org/cpython/rev/a7082e2898aa

    New changeset f7c012ff33cb by Serhiy Storchaka in branch '3.4':
    Issue bpo-21522: Added Tkinter tests for Listbox.itemconfigure(),
    http://hg.python.org/cpython/rev/f7c012ff33cb

    New changeset 4034c96a98a7 by Serhiy Storchaka in branch 'default':
    Issue bpo-21522: Added Tkinter tests for Listbox.itemconfigure(),
    http://hg.python.org/cpython/rev/4034c96a98a7

    @ned-deily
    Copy link
    Member

    Failing tests with Tk 8.4 (Carbon Tk 8.4.20 on OS X):

    ======================================================================
    ERROR: test_paneconfigure_hide (tkinter.test.test_tkinter.test_widgets.PanedWindowTest)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
  File "/py/dev/3x/root/fwd/Library/Frameworks/pytest_10.9.framework/Versions/3.5/lib/python3.5/tkinter/test/test_tkinter/test_widgets.py", line 995, in test_paneconfigure_hide
    self.check_paneconfigure(p, b, 'hide', False, 0)
  File "/py/dev/3x/root/fwd/Library/Frameworks/pytest_10.9.framework/Versions/3.5/lib/python3.5/tkinter/test/test_tkinter/test_widgets.py", line 967, in check_paneconfigure
    p.paneconfigure(b, **{name: value})
  File "/py/dev/3x/root/fwd/Library/Frameworks/pytest_10.9.framework/Versions/3.5/lib/python3.5/tkinter/__init__.py", line 3818, in paneconfigure
    self._options(cnf, kw))
_tkinter.TclError: unknown option "-hide"

    ======================================================================
    ERROR: test_paneconfigure_stretch (tkinter.test.test_tkinter.test_widgets.PanedWindowTest)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
  File "/py/dev/3x/root/fwd/Library/Frameworks/pytest_10.9.framework/Versions/3.5/lib/python3.5/tkinter/test/test_tkinter/test_widgets.py", line 1027, in test_paneconfigure_stretch
    self.check_paneconfigure(p, b, 'stretch', 'alw', 'always')
  File "/py/dev/3x/root/fwd/Library/Frameworks/pytest_10.9.framework/Versions/3.5/lib/python3.5/tkinter/test/test_tkinter/test_widgets.py", line 967, in check_paneconfigure
    p.paneconfigure(b, **{name: value})
  File "/py/dev/3x/root/fwd/Library/Frameworks/pytest_10.9.framework/Versions/3.5/lib/python3.5/tkinter/__init__.py", line 3818, in paneconfigure
    self._options(cnf, kw))
_tkinter.TclError: unknown option "-stretch"

    ======================================================================
    FAIL: test_paneconfigure_height (tkinter.test.test_tkinter.test_widgets.PanedWindowTest)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
  File "/py/dev/3x/root/fwd/Library/Frameworks/pytest_10.9.framework/Versions/3.5/lib/python3.5/tkinter/test/test_tkinter/test_widgets.py", line 989, in test_paneconfigure_height
    self.check_paneconfigure(p, b, 'height', 10, 10)
  File "/py/dev/3x/root/fwd/Library/Frameworks/pytest_10.9.framework/Versions/3.5/lib/python3.5/tkinter/test/test_tkinter/test_widgets.py", line 968, in check_paneconfigure
    self.assertEqual(p.paneconfigure(b, name)[4], expected)
AssertionError: <pixel object: '10'> != 10

    ======================================================================
    FAIL: test_paneconfigure_width (tkinter.test.test_tkinter.test_widgets.PanedWindowTest)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
  File "/py/dev/3x/root/fwd/Library/Frameworks/pytest_10.9.framework/Versions/3.5/lib/python3.5/tkinter/test/test_tkinter/test_widgets.py", line 1034, in test_paneconfigure_width
    self.check_paneconfigure(p, b, 'width', 10, 10)
  File "/py/dev/3x/root/fwd/Library/Frameworks/pytest_10.9.framework/Versions/3.5/lib/python3.5/tkinter/test/test_tkinter/test_widgets.py", line 968, in check_paneconfigure
    self.assertEqual(p.paneconfigure(b, name)[4], expected)
AssertionError: <pixel object: '10'> != 10

    @ned-deily ned-deily reopened this May 23, 2014
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented May 23, 2014

    New changeset c7ee46ed2d70 by Serhiy Storchaka in branch '2.7':
    Fixed new Tkinter tests added in issue bpo-21522 with Tk 8.4.
    http://hg.python.org/cpython/rev/c7ee46ed2d70

    New changeset 854404294f34 by Serhiy Storchaka in branch '3.4':
    Fixed new Tkinter tests added in issue bpo-21522 with Tk 8.4.
    http://hg.python.org/cpython/rev/854404294f34

    New changeset 1079772e7309 by Serhiy Storchaka in branch 'default':
    Fixed new Tkinter tests added in issue bpo-21522 with Tk 8.4.
    http://hg.python.org/cpython/rev/1079772e7309

    @serhiy-storchaka
    Copy link
    Member Author

    Thank you Ned. My fault.

    @ned-deily
    Copy link
    Member

    Yes, that fixes 8.4, thanks!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @serhiy-storchaka serhiy-storchaka

    Labels
    tests Tests in the Lib/test dir topic-tkinter type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @serhiy-storchaka @ned-deily