Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for ntpath.expanduser #65692

Closed
PCManticore mannequin opened this issue May 13, 2014 · 5 comments
Closed

Add test for ntpath.expanduser #65692

PCManticore mannequin opened this issue May 13, 2014 · 5 comments
Assignees
@serhiy-storchaka
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@PCManticore
Copy link
Mannequin

PCManticore mannequin commented May 13, 2014

BPO 21493
Nosy @PCManticore, @serhiy-storchaka
Files
  • expanduser.patch
  • issue21493.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2014-05-28.15:39:31.309>
created_at = <Date 2014-05-13.10:12:40.242>
labels = ['type-feature', 'tests']
title = 'Add test for ntpath.expanduser'
updated_at = <Date 2014-05-28.15:39:31.292>
user = 'https://github.com/PCManticore'

    bugs.python.org fields:

    activity = <Date 2014-05-28.15:39:31.292>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2014-05-28.15:39:31.309>
closer = 'serhiy.storchaka'
components = ['Tests']
creation = <Date 2014-05-13.10:12:40.242>
creator = 'Claudiu.Popa'
dependencies = []
files = ['35239', '35355']
hgrepos = []
issue_num = 21493
keywords = ['patch']
message_count = 5.0
messages = ['218427', '219102', '219104', '219275', '219279']
nosy_count = 3.0
nosy_names = ['Claudiu.Popa', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue21493'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5']
    @PCManticore
    Copy link
    Mannequin Author

    PCManticore mannequin commented May 13, 2014

    Hello. This patch adds a test for ntpath.expanduser, which was missing. Also, it increases the test coverage for ntpath.py from 68% to 75%.

    @PCManticore PCManticore mannequin added tests Tests in the Lib/test dir type-feature A feature request or enhancement labels May 13, 2014
    @serhiy-storchaka
    Copy link
    Member

    LGTM. But most other tests in this file use tester() to test str and bytes. And it would be good to test multicomponent arguments (e.g. '~test\\foo\\bar' and '~/foo/bar').

    @serhiy-storchaka serhiy-storchaka self-assigned this May 25, 2014
    @PCManticore
    Copy link
    Mannequin Author

    PCManticore mannequin commented May 25, 2014

    Here's an updated patch.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented May 28, 2014

    New changeset 5e599b301ebd by Serhiy Storchaka in branch '2.7':
    Issue bpo-21493: Added test for ntpath.expanduser(). Original patch by
    http://hg.python.org/cpython/rev/5e599b301ebd

    New changeset a981a088512c by Serhiy Storchaka in branch '3.4':
    Issue bpo-21493: Added test for ntpath.expanduser(). Original patch by
    http://hg.python.org/cpython/rev/a981a088512c

    New changeset 5a71a7e60fe6 by Serhiy Storchaka in branch 'default':
    Issue bpo-21493: Added test for ntpath.expanduser(). Original patch by
    http://hg.python.org/cpython/rev/5a71a7e60fe6

    @serhiy-storchaka
    Copy link
    Member

    Thanks Claudiu.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @serhiy-storchaka serhiy-storchaka

    Labels
    tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @serhiy-storchaka