Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip 2 tests in test_urllib2net.py if _ssl module not present #65655

Closed
rpointel mannequin opened this issue May 9, 2014 · 5 comments
Closed

skip 2 tests in test_urllib2net.py if _ssl module not present #65655

rpointel mannequin opened this issue May 9, 2014 · 5 comments
Assignees
@berkerpeksag
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@rpointel
Copy link
Mannequin

rpointel mannequin commented May 9, 2014

BPO 21456
Nosy @pitrou, @berkerpeksag
Files
  • Lib_test_test_urllib2net_py.diff: diff to skip 2 tests in Lib/test/test_urllib2net.py if ssl module not present
  • Lib_test_test_urllib2net_py.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/berkerpeksag'
closed_at = <Date 2014-10-10.11:36:37.452>
created_at = <Date 2014-05-09.07:03:50.306>
labels = ['type-bug', 'tests']
title = 'skip 2 tests in test_urllib2net.py if _ssl module not present'
updated_at = <Date 2014-10-10.11:36:37.450>
user = 'https://bugs.python.org/rpointel'

    bugs.python.org fields:

    activity = <Date 2014-10-10.11:36:37.450>
actor = 'berker.peksag'
assignee = 'berker.peksag'
closed = True
closed_date = <Date 2014-10-10.11:36:37.452>
closer = 'berker.peksag'
components = ['Tests']
creation = <Date 2014-05-09.07:03:50.306>
creator = 'rpointel'
dependencies = []
files = ['35192', '35505']
hgrepos = []
issue_num = 21456
keywords = ['patch']
message_count = 5.0
messages = ['218139', '218152', '219918', '228985', '228987']
nosy_count = 4.0
nosy_names = ['pitrou', 'python-dev', 'rpointel', 'berker.peksag']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue21456'
versions = ['Python 3.4', 'Python 3.5']
    @rpointel
    Copy link
    Mannequin Author

    rpointel mannequin commented May 9, 2014

    Hi,

    I tested the regress tests on a machine which does not have the ssl module, and I have 2 errors in Lib/test/test_urllib2net.py. I think it should skip the test instead.

    Attached is a diff I wrote, it's based on Lib/test/test_poplib.py.

    Don't hesitate if I miss a thing.

    Remi.

    @rpointel rpointel mannequin added the tests Tests in the Lib/test dir label May 9, 2014
    @pitrou
    Copy link
    Member

    pitrou commented May 9, 2014

    There isn't much point in introducing a variable named SUPPORTS_SSL, just use "ssl is not None".

    @rpointel
    Copy link
    Mannequin Author

    rpointel mannequin commented Jun 7, 2014

    Are you ok with this diff reworked?

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 10, 2014

    New changeset ac55331c1df6 by Berker Peksag in branch '3.4':
    Issue bpo-21456: Skip two tests in test_urllib2net.py if _ssl module not present.
    https://hg.python.org/cpython/rev/ac55331c1df6

    New changeset 470ea66f5bee by Berker Peksag in branch 'default':
    Issue bpo-21456: Skip two tests in test_urllib2net.py if _ssl module not present.
    https://hg.python.org/cpython/rev/470ea66f5bee

    @berkerpeksag
    Copy link
    Member

    Thanks for the patch, Remi.

    @berkerpeksag berkerpeksag self-assigned this Oct 10, 2014
    @berkerpeksag berkerpeksag added the type-bug An unexpected behavior, bug, or error label Oct 10, 2014
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @berkerpeksag berkerpeksag

    Labels
    tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @berkerpeksag @pitrou