Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor and fix curses configure checks #65484

Closed
doko42 opened this issue Apr 17, 2014 · 5 comments
Closed

refactor and fix curses configure checks #65484

doko42 opened this issue Apr 17, 2014 · 5 comments
Labels
build The build process and cross-build

Comments

@doko42
Copy link
Member

doko42 commented Apr 17, 2014

BPO 21285
Nosy @Yhg1s, @doko42, @vstinner
Files
  • ncurses-configure.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2014-04-17.20:12:21.769>
created_at = <Date 2014-04-17.16:04:16.187>
labels = ['build']
title = 'refactor and fix curses configure checks'
updated_at = <Date 2014-04-17.20:12:21.768>
user = 'https://github.com/doko42'

    bugs.python.org fields:

    activity = <Date 2014-04-17.20:12:21.768>
actor = 'doko'
assignee = 'none'
closed = True
closed_date = <Date 2014-04-17.20:12:21.769>
closer = 'doko'
components = ['Build']
creation = <Date 2014-04-17.16:04:16.187>
creator = 'doko'
dependencies = []
files = ['34949']
hgrepos = []
issue_num = 21285
keywords = ['patch']
message_count = 5.0
messages = ['216704', '216719', '216721', '216722', '216736']
nosy_count = 4.0
nosy_names = ['twouters', 'doko', 'vstinner', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue21285'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5']
    @doko42
    Copy link
    Member Author

    doko42 commented Apr 17, 2014

    this refactors the curses configure checks, and fixes the build with ncursesw. In it's current form the curses feature checks are run without the additional include path which leads to wrong results if the only the nurses headers are installed.

    @doko42 doko42 added the build The build process and cross-build label Apr 17, 2014
    @Yhg1s
    Copy link
    Member

    Yhg1s commented Apr 17, 2014

    Good fix. Do remove the 'first curses header check' comment you add, and don't forget to regenerate configure (and maybe pyconfig.h.in? I don't know if that'll change.)

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Apr 17, 2014

    New changeset 1bc0a8310b9f by doko in branch '2.7':

    New changeset 635817da596d by doko in branch '3.4':

    @doko42
    Copy link
    Member Author

    doko42 commented Apr 17, 2014

    looks like with this change the curses extension isn't built anymore on Solaris.

    @doko42 doko42 changed the title refactor anfd fix curses configure checks refactor and fix curses configure checks Apr 17, 2014
    @doko42
    Copy link
    Member Author

    doko42 commented Apr 17, 2014

    Victor pointer out the Solaris issue is unrelated. See bpo-13552. Closing.

    @doko42 doko42 closed this as completed Apr 17, 2014
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    build The build process and cross-build
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @Yhg1s @doko42