Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

define PATH_MAX for GNU/Hurd in Python/pythonrun.c #65473

Closed
doko42 opened this issue Apr 16, 2014 · 8 comments
Closed

define PATH_MAX for GNU/Hurd in Python/pythonrun.c #65473

doko42 opened this issue Apr 16, 2014 · 8 comments
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@doko42
Copy link
Member

doko42 commented Apr 16, 2014

BPO 21274
Nosy @loewis, @Yhg1s, @doko42, @vstinner, @berkerpeksag
Files
  • hurd-path_max.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2016-04-16.17:34:15.817>
created_at = <Date 2014-04-16.22:32:56.136>
labels = ['interpreter-core']
title = 'define PATH_MAX for GNU/Hurd in Python/pythonrun.c'
updated_at = <Date 2016-04-16.17:34:15.725>
user = 'https://github.com/doko42'

    bugs.python.org fields:

    activity = <Date 2016-04-16.17:34:15.725>
actor = 'berker.peksag'
assignee = 'none'
closed = True
closed_date = <Date 2016-04-16.17:34:15.817>
closer = 'berker.peksag'
components = ['Interpreter Core']
creation = <Date 2014-04-16.22:32:56.136>
creator = 'doko'
dependencies = []
files = ['34933']
hgrepos = []
issue_num = 21274
keywords = ['patch']
message_count = 8.0
messages = ['216611', '216712', '216718', '216723', '230663', '230680', '230683', '263568']
nosy_count = 6.0
nosy_names = ['loewis', 'twouters', 'doko', 'vstinner', 'python-dev', 'berker.peksag']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue21274'
versions = ['Python 3.4', 'Python 3.5']
    @doko42
    Copy link
    Member Author

    doko42 commented Apr 16, 2014

    PATH_MAX is not defined on GNU/Hurd. Take the same approach as taken for Windows in the very same file and define it in terms of MAXPATHLEN.

    @doko42 doko42 added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Apr 16, 2014
    @Yhg1s
    Copy link
    Member

    Yhg1s commented Apr 17, 2014

    You should put the definition closer to the Windows one (right after or before it) rather than further down the file. Other than that, looks good.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Apr 17, 2014

    New changeset ca2edbefca35 by doko in branch '3.4':
    Fixes for KFreeBSD and the Hurd:
    http://hg.python.org/cpython/rev/ca2edbefca35

    @doko42
    Copy link
    Member Author

    doko42 commented Apr 17, 2014

    fixed

    @doko42 doko42 closed this as completed Apr 17, 2014
    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Nov 5, 2014

    Reopening. What problem does this fix? AFAICT, PATH_MAX isn't used at all (anymore).

    @loewis loewis mannequin reopened this Nov 5, 2014
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 5, 2014

    New changeset d6fb87972dee by Victor Stinner in branch 'default':
    Issue bpo-20597, bpo-21274: Remove unused definition of PATH_MAX on GNU/Hurd,
    https://hg.python.org/cpython/rev/d6fb87972dee

    @vstinner
    Copy link
    Member

    vstinner commented Nov 5, 2014

    In Python 3.5, PATH_MAX is no more used in Modules/main.c nor Python/pythonrun.c. I removed the "#define PATH_MAX ..." on Hurd.

    I didn't check Python 3.4.

    @berkerpeksag
    Copy link
    Member

    Python 3.4 is in security-fix-only mode so we can close this now.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @berkerpeksag @vstinner @Yhg1s @doko42