Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use _sysconfigdata to itinialize distutils.sysconfig #65471

Closed
doko42 opened this issue Apr 16, 2014 · 7 comments
Closed

use _sysconfigdata to itinialize distutils.sysconfig #65471

doko42 opened this issue Apr 16, 2014 · 7 comments
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@doko42
Copy link
Member

doko42 commented Apr 16, 2014

BPO 21272
Nosy @warsaw, @doko42, @merwok, @haubi, @dstufft
Files
  • distutils-init.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2016-06-04.23:18:23.141>
created_at = <Date 2014-04-16.22:12:08.390>
labels = ['type-feature', 'library']
title = 'use _sysconfigdata to itinialize distutils.sysconfig'
updated_at = <Date 2017-01-24.00:49:45.130>
user = 'https://github.com/doko42'

    bugs.python.org fields:

    activity = <Date 2017-01-24.00:49:45.130>
actor = 'martin.panter'
assignee = 'none'
closed = True
closed_date = <Date 2016-06-04.23:18:23.141>
closer = 'doko'
components = ['Distutils']
creation = <Date 2014-04-16.22:12:08.390>
creator = 'doko'
dependencies = []
files = ['34931']
hgrepos = []
issue_num = 21272
keywords = ['patch']
message_count = 7.0
messages = ['216609', '216645', '216658', '216751', '216754', '216756', '267343']
nosy_count = 7.0
nosy_names = ['barry', 'doko', 'eric.araujo', 'Arfrever', 'haubi', 'python-dev', 'dstufft']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'patch review'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue21272'
versions = ['Python 3.6']
    @doko42
    Copy link
    Member Author

    doko42 commented Apr 16, 2014

    distutils/sysconfig still parses the Makefile and config header; it should use the same approach now as the toplevel sysconfig module.

    @doko42 doko42 added the stdlib Python modules in the Lib dir label Apr 16, 2014
    @pitrou pitrou added the type-feature A feature request or enhancement label Apr 17, 2014
    @warsaw
    Copy link
    Member

    warsaw commented Apr 17, 2014

    On Apr 16, 2014, at 10:12 PM, Matthias Klose wrote:

    distutils/sysconfig still parses the Makefile and config header; it should
    use the same approach now as the toplevel sysconfig module.

    Why do we still have two sysconfig modules?

    @warsaw warsaw changed the title use _sysconfigdata.py in distutils.sysconfig to initialize distutils.sysconfig use _sysconfigdata.py in distutils.sysconfig to initialize distutils.sysconfig Apr 17, 2014
    @merwok
    Copy link
    Member

    merwok commented Apr 17, 2014

    Because removing distutils.sysconfig would break things.

    @Arfrever
    Copy link
    Mannequin

    Arfrever mannequin commented Apr 17, 2014

    Maybe distutils.sysconfig could become a small wrapper around sysconfig?

    @merwok
    Copy link
    Member

    merwok commented Apr 17, 2014

    Sure. The API is slightly different, but the data should be the same, so this can be done.

    @merwok merwok added stdlib Python modules in the Lib dir and removed stdlib Python modules in the Lib dir labels Apr 17, 2014
    @merwok merwok changed the title use _sysconfigdata.py in distutils.sysconfig to initialize distutils.sysconfig use _sysconfigdata to itinialize distutils.sysconfig Apr 17, 2014
    @merwok
    Copy link
    Member

    merwok commented Apr 17, 2014

    doko’s patch is actually conservative, not changing the query functions of distutils.sysconfig but only the _init_posix function, which just defines a global dict. It looks quite safe to me.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jun 4, 2016

    New changeset 3fa8aebed636 by doko in branch 'default':

    @doko42 doko42 closed this as completed Jun 4, 2016
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @warsaw @merwok @pitrou @doko42