Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asyncio: calling _UnixSelectorEventLoop.create_unix_server(sock=..., path=...) must fail #65354

Closed
vstinner opened this issue Apr 4, 2014 · 2 comments

Comments

@vstinner
Copy link
Member

vstinner commented Apr 4, 2014

BPO 21155
Nosy @gvanrossum, @vstinner, @1st1
Files
  • unix.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2014-04-07.09:23:26.448>
    created_at = <Date 2014-04-04.16:57:31.659>
    labels = []
    title = 'asyncio: calling _UnixSelectorEventLoop.create_unix_server(sock=..., path=...) must fail'
    updated_at = <Date 2014-04-07.09:23:26.448>
    user = 'https://github.com/vstinner'

    bugs.python.org fields:

    activity = <Date 2014-04-07.09:23:26.448>
    actor = 'vstinner'
    assignee = 'none'
    closed = True
    closed_date = <Date 2014-04-07.09:23:26.448>
    closer = 'vstinner'
    components = []
    creation = <Date 2014-04-04.16:57:31.659>
    creator = 'vstinner'
    dependencies = []
    files = ['34726']
    hgrepos = []
    issue_num = 21155
    keywords = ['patch']
    message_count = 2.0
    messages = ['215536', '215679']
    nosy_count = 4.0
    nosy_names = ['gvanrossum', 'vstinner', 'python-dev', 'yselivanov']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue21155'
    versions = ['Python 3.4', 'Python 3.5']

    @vstinner
    Copy link
    Member Author

    vstinner commented Apr 4, 2014

    _UnixSelectorEventLoop.create_unix_server() can be called with path *and* sock. In this case, the sock parameter is ignored.

    Attached patch changes the method to raise a ValueError, to have the same behaviour than create_connection().

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Apr 7, 2014

    New changeset a6b764848b20 by Victor Stinner in branch '3.4':
    Issue bpo-21155: asyncio.EventLoop.create_unix_server() now raises a ValueError if
    http://hg.python.org/cpython/rev/a6b764848b20

    New changeset 34ace7eb67e9 by Victor Stinner in branch 'default':
    (Merge 3.4) Issue bpo-21155: asyncio.EventLoop.create_unix_server() now raises a
    http://hg.python.org/cpython/rev/34ace7eb67e9

    @vstinner vstinner closed this as completed Apr 7, 2014
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant