New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idle: change default reformat width from 70 to 72 #65338
Comments
Changing the default in the default configuration file is trivial. In test_formatparagraph.FormatEventTest, test_comment_block and test_long_line currently fail if the reformat width is changed on the General tab of the configuration dialog. These tests will need to be altered when the default is changed. Also, the tests should temporarily change the reformat width to the presumed default in the class setup and teardown methods. If this is not possible, the tests should be skipped if it is not what the test requires. |
Attaching a patch for 2.7 and 3.4 |
I am puzzled at the differences between the 2.7 and 3.4 patches. There are only three differences between the files - from Tkinter import Tk, Text, TclError
+ from tkinter import Tk, Text, TclError
? ^
- from test.test_support import requires
+ from test.support import requires
? ^
- get_selection_indices = EditorWindow.get_selection_indices.im_func
+ get_selection_indices = EditorWindow. get_selection_indices
and none of these should affect the patch. The attached patch adds a limit parameter to the FormatParagraph.format_paragraph_event method ReformatParagraph.py that is called as self.formatter in the tests. |
I applied my patch as part of bpo-21284. When I did so, I added 'limit=70' so that the tests pass otherwise unchanged. The only thing left here is to change config-main.def. |
I put 21138 in the commit message. The push messages are these. New changeset dd24099c0cf6 by Terry Jan Reedy in branch '3.4': |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: