Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyArena type is used in headers from the limited API #65319

Closed
aponomarenko mannequin opened this issue Apr 1, 2014 · 4 comments
Closed

PyArena type is used in headers from the limited API #65319

aponomarenko mannequin opened this issue Apr 1, 2014 · 4 comments
Labels
3.9 only security fixes build The build process and cross-build

Comments

@aponomarenko
Copy link
Mannequin

aponomarenko mannequin commented Apr 1, 2014

BPO 21120
Nosy @loewis, @jcea, @markshannon, @ZackerySpytz
PRs
  • bpo-21120: Exclude Python-ast.h, ast.h and asdl.h from the limited API #14634
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-09-12.09:30:33.036>
created_at = <Date 2014-04-01.08:10:21.708>
labels = ['build', '3.9']
title = 'PyArena type is used in headers from the limited API'
updated_at = <Date 2019-09-12.09:30:33.035>
user = 'https://bugs.python.org/aponomarenko'

    bugs.python.org fields:

    activity = <Date 2019-09-12.09:30:33.035>
actor = 'Mark.Shannon'
assignee = 'none'
closed = True
closed_date = <Date 2019-09-12.09:30:33.036>
closer = 'Mark.Shannon'
components = ['Build']
creation = <Date 2014-04-01.08:10:21.708>
creator = 'aponomarenko'
dependencies = []
files = []
hgrepos = []
issue_num = 21120
keywords = ['patch']
message_count = 4.0
messages = ['215300', '238955', '351386', '352071']
nosy_count = 5.0
nosy_names = ['loewis', 'jcea', 'Mark.Shannon', 'aponomarenko', 'ZackerySpytz']
pr_nums = ['14634']
priority = 'normal'
resolution = None
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue21120'
versions = ['Python 3.9']
    @aponomarenko
    Copy link
    Mannequin Author

    aponomarenko mannequin commented Apr 1, 2014

    Hi all,

    The PyArena data type is defined in the pyarena.h under the #ifndef Py_LIMITED_API statement, so it's not included in the limited api. But this type is used in Python-ast.h, ast.h and asdl.h headers that included in the limited api, because they don't contain any checks for Py_LIMITED_API.

    May be all these header files (Python-ast.h, ast.h, asdl.h) should begin with "#ifndef Py_LIMITED_API" (excluded from the limited api)?

    Thanks.

    @aponomarenko aponomarenko mannequin added stdlib Python modules in the Lib dir build The build process and cross-build labels Apr 1, 2014
    @BreamoreBoy
    Copy link
    Mannequin

    BreamoreBoy mannequin commented Mar 22, 2015

    I'm not sure if this should be a compile error or an enhancement request, can someone please advise.

    @ZackerySpytz ZackerySpytz mannequin added build The build process and cross-build 3.9 only security fixes and removed stdlib Python modules in the Lib dir labels Jul 7, 2019
    @markshannon
    Copy link
    Member

    This seems like the correct thing to do.
    Since the AST changes from version to version, I don't see how these files could reasonably be part of the limited API.

    @markshannon
    Copy link
    Member

    New changeset 421a72a by Mark Shannon (Zackery Spytz) in branch 'master':
    bpo-21120: Exclude Python-ast.h, ast.h and asdl.h from the limited API (bpo-14634)
    421a72a

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes build The build process and cross-build
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @markshannon